Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Added visual tests #13

Merged
merged 38 commits into from
Mar 7, 2022
Merged

ci: Added visual tests #13

merged 38 commits into from
Mar 7, 2022

Conversation

bentleyvk
Copy link
Contributor

@bentleyvk bentleyvk commented Feb 24, 2022

  • I tried to use cypress components tests but I couldn't make them work because:
    • At first I had problems with esbuild since it has different binaries for different OS but I found workaround to run npm rebuild esbuild in Docker container.
    • Then I encountered issue related to monorepo as inside packages are symlinked and Windows links doesn't work in Linux container. If I relinked manually in container, then build won't work in Windows. Dockerfile ADD command does not follow symlinks on host moby/moby#1676
  • I wanted to make that dev server is running on host and Docker container runs tests on it. It worked on my machine but it didn't work on CI. I tried different Docker arguments and other hacks but just running built demo page inside container seemed to be simpler solution.
  • There are several different cypress visual testing plugins but cypress-image-diff-js has better API, report showing and more recent updates when others' last release date is 1-2 years ago.
  • I decided to use 4K, Full HD, 1366x768 (20% of desktop users screen resolution), Tablet and Mobile breakpoints for testing.
  • I added react-router-dom for better navigation.
  • I added CONTRIBUTING.md with some explanations but it is still WIP.

Closes #7

@FlyersPh9
Copy link
Collaborator

I don't know if this is something I can review.

@bentleyvk bentleyvk marked this pull request as ready for review March 1, 2022 09:34
.github/workflows/build.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
demo/cypress/common/layoutDescribe.ts Show resolved Hide resolved
demo/src/types.d.ts Show resolved Hide resolved
demo/tsconfig.json Show resolved Hide resolved
package.json Show resolved Hide resolved
demo/package.json Show resolved Hide resolved
demo/entrypoint.sh Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gretanausedaite gretanausedaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌤️

@bentleyvk bentleyvk merged commit fb48ce0 into main Mar 7, 2022
@bentleyvk bentleyvk deleted the vilius/visual-tests branch March 7, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research how to test our layout components
5 participants