Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tiles to home page #20

Merged
merged 40 commits into from
Apr 12, 2022
Merged

Add tiles to home page #20

merged 40 commits into from
Apr 12, 2022

Conversation

FlyersPh9
Copy link
Collaborator

@FlyersPh9 FlyersPh9 commented Mar 10, 2022 •
edited by gretanausedaite
Loading

  • Add tiles to home page.
  • Renamed templates.
  • Header & side navigation react to the content of the page.

Closes #19.

image

@FlyersPh9 FlyersPh9 self-assigned this Mar 10, 2022
@FlyersPh9 FlyersPh9 changed the base branch from main to greta/tiles-layout March 10, 2022 17:31
FlyersPh9
FlyersPh9 commented Mar 10, 2022
View reviewed changes
demo/src/App.tsx Outdated Show resolved Hide resolved
@FlyersPh9 FlyersPh9 changed the title first push Add tiles to home page Mar 10, 2022
@bentleyvk
Copy link
Contributor

bentleyvk commented Mar 16, 2022 •
edited
Loading

Why you are targeting Greta's PR? It will make it even bigger, let's try to make small and one issue targeting PRs. So please make merge target the main branch.

Base automatically changed from greta/tiles-layout to main March 31, 2022 10:51
@gretanausedaite gretanausedaite marked this pull request as ready for review April 1, 2022 10:32
@bentleyvk
Copy link
Contributor

Is it ready for review?

@gretanausedaite
Copy link
Contributor

Is it ready for review?

Yes.

bentleyvk
bentleyvk reviewed Apr 6, 2022
View reviewed changes
demo/src/demos/list.tsx Outdated Show resolved Hide resolved
bentleyvk
bentleyvk reviewed Apr 6, 2022
View reviewed changes
demo/src/App.tsx
</li>
<FluidGrid>
{DEMOS_LIST.map(({ path, name, description, icon }) => (
<div
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed View button and made Tiles clickable. I think Jon wanted to achieve that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tiles are clickable, maybe it makes sense to add hover effects?

Copy link
Collaborator Author

@FlyersPh9 FlyersPh9 Apr 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR added to iTwin/iTwinUI#579

I will be off work tomorrow and maybe on Monday, feel free to make changes / merge the PR while I am gone.

@FlyersPh9 FlyersPh9 mentioned this pull request Apr 7, 2022
Merged
bentleyvk
bentleyvk reviewed Apr 11, 2022
View reviewed changes
demo/src/demos/list.tsx Outdated Show resolved Hide resolved
bentleyvk
bentleyvk reviewed Apr 11, 2022
View reviewed changes
demo/src/demos/list.tsx Outdated Show resolved Hide resolved
bentleyvk
bentleyvk approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@bentleyvk bentleyvk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add tile hover later

@gretanausedaite gretanausedaite merged commit 07727e1 into main Apr 12, 2022
@gretanausedaite gretanausedaite deleted the jon/home-page-tiles branch April 12, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretanausedaite gretanausedaite gretanausedaite left review comments

@bentleyvk bentleyvk bentleyvk approved these changes

Assignees

@gretanausedaite gretanausedaite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home page update
3 participants
@FlyersPh9 @bentleyvk @gretanausedaite