Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small visual changes and tweaks #37

Merged
merged 23 commits into from
May 6, 2022
Merged

Small visual changes and tweaks #37

merged 23 commits into from
May 6, 2022

Conversation

gretanausedaite
Copy link
Contributor

@gretanausedaite gretanausedaite commented Apr 29, 2022

image

PageLayout 2 demo will be replaced with Table demo.

  • Updated file names and structure
  • Update content as docks

Closes #36

@gretanausedaite gretanausedaite marked this pull request as ready for review May 3, 2022 11:04
demo/src/common/DemoHomePageInfoCard.scss Outdated Show resolved Hide resolved
demo/src/common/DemoSurfaceCard.scss Outdated Show resolved Hide resolved
@gretanausedaite
Copy link
Contributor Author

Padded layout needs width: 100% because in larger screens it takes less than 1440px.

@bentleyvk
Copy link
Contributor

Can you rename to lowercase "layouts" like in this PR #33? Then we could close it.

@@ -2,4 +2,5 @@
* Copyright (c) Bentley Systems, Incorporated. All rights reserved.
* See LICENSE.md in the project root for license terms and full copyright notice.
*--------------------------------------------------------------------------------------------*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line still remained untouched 😀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :)

Copy link
Contributor

@bentleyvk bentleyvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gretanausedaite gretanausedaite merged commit f5335a1 into main May 6, 2022
@gretanausedaite gretanausedaite deleted the greta/small-stuff branch May 6, 2022 08:35
@bentleyvk bentleyvk mentioned this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small changes for release
2 participants