chore: Use iTwinUI-Variables in CSS package #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should update layouts package versions. Are we going 1.0.0 here too or 0.2.0 is ok? @bentleyvk |
bentleyvk
reviewed
Nov 11, 2022
|
|
||
| .app { | ||
| padding: $iui-line-height unquote('max(#{$iui-l}, #{$iui-l} + env(safe-area-inset-right))') $iui-line-height unquote('max(#{$iui-l}, #{$iui-l} + env(safe-area-inset-left))'); | ||
| padding: var(--iui-size-l) unquote('max(var(--iui-size-l), var(--iui-size-l) + env(safe-area-inset-right))') var(--iui-size-l) unquote('max(var(--iui-size-l), var(--iui-size-l) + env(safe-area-inset-left))'); |
There was a problem hiding this comment.
It would be good to have alias for line-height in variables package
|
|
||
| &-icon { | ||
| width: 20%; | ||
| background-color: var(--iui-color-background-3); | ||
| border-right: 1px solid var(--iui-color-background-5); | ||
| background-color: var(--iui-color-background-zebra); |
|
|
||
| .demo-template-container { | ||
| display: flex; | ||
| height: 100vh; | ||
| background-color: var(--iui-color-background-4); |
| justify-content: space-between; | ||
|
|
||
| &-left, | ||
| &-right { | ||
| display: flex; | ||
| justify-content: flex-start; | ||
| flex-direction: row; | ||
| gap: $iui-s; | ||
| gap: var(--iui-size-xs); |
There was a problem hiding this comment.
Only now I understand that our example doesn't have several buttons or inputs in tools area to see how gap looks like. But it is not for this PR.
gretanausedaite
changed the title
gretanausedaite
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0.0.1.0.0.