Floating UI safePolygon for non-last MenuItems
#2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
Ben-Pusey-Bentley
and removed request for
a team
16 tasks
Ben-Pusey-Bentley
approved these changes
May 6, 2024
mayank99
reviewed
May 6, 2024
mayank99
reviewed
May 6, 2024
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
mayank99
reviewed
May 6, 2024
mayank99
approved these changes
May 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After PR TODO from #1942 (#1942 (comment)).
To make the
safePolygonwork for even the non-lastMenuItems, looks like we needed to setblockPointerEvents: true. This PR makes that change.This change is done in
usePopoverinstead ofMenuItembecauseMenuItemis the only component that has been using the hover trigger so far. So, making this change inusePopoveris alright since it will not affect any other user component or our own internal component.Additionally, to make it easier for users to hover over adjacent items instead of keeping the submenu open,
requireIntent: falseis removed (#2026 (comment)).Testing
safePolygonworks for non-lastMenuItems too.Screen-recordings
Before:
Enregistrement.de.l.ecran.2024-05-03.a.23.32.42.mov
After:
Enregistrement.de.l.ecran.2024-05-03.a.23.30.52.mov
Docs
Added changesets.