add "open" popover styling to buttons #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
apps/react-workshop/cypress-visual-screenshots/baseline/DatePicker.test.ts-Basic.png
Outdated
Show resolved
Hide resolved
apps/react-workshop/cypress-visual-screenshots/baseline/Table.test.ts-Full2.png
Outdated
Show resolved
Hide resolved
Ben-Pusey-Bentley
approved these changes
May 31, 2024
r100-stack
reviewed
May 31, 2024
r100-stack
approved these changes
May 31, 2024
|
Waiting for @FlyersPh9 to create a PR moving icon fills to field CSS (see thread), because that change will likely affect visuals in this PR. |
#2088 is merging any minute. |
mayank99
force-pushed
the
mayank/popover-open
branch
from
231481a
to
eba74e9
Compare
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds "open" state styling to buttons that have a popover (or dropdown menu) that is currently open. Right now, it just reuses hover state styling, which is a subtle, non-offensive choice. (Can be made more noticeable in the future if desired)
Builds upon #2075.
CSS
The hover state is toggled on when the popover is open. This is done at the
iui-buttonlevel (we can think about adding it to other fields in the future if needed).I used a data attribute (
data-iui-has-popover) and also added:has(+ :popover-open)as a hook that we can rely on in the future if we use thepopoverAPI in more places.React
A new
PopoverOpenContextis exported. Its value is provided in multiple components where a trigger element is present.ButtonandIconButtonread from this context and set the data attribute accordingly.Testing
Added unit tests that either directly or indirectly check the affected code paths.
Updated affected visual test images. (Not sure why the focus moved in some cases; probably some flakyness).
Manually tested a whole bunch of stories that are affected. I encourage reviewers to do the same. (Start with DropdownButton for example)
Screen.Recording.2024-05-30.at.4.05.57.PM.mov
Docs
Added changesets for CSS and React.