-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Color Picker #253
Conversation
3 major things from my perfunctory look before I do any "review":
1 minor thing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expanding a bit on my points above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the advanced part could use some restructuring/cleanup.
Maybe @FlyersPh9 could provide some guidance on the values/visuals
We discussed in a call to have the basic color picker's width be responsive. If there are only 2 color swatches, the width will shrink to fit the 2 swatches. If there are above 10 swatches, we will wrap the swatches to a new line so that only 10 swatches are on a row. For the advanced color picker, the width will always be the same no matter how many saved colors are listed. |
We also discussed in a call setting a max-height on the color swatches. If we have a scenario where we have dozens of rows that we will only display so many rows (undecided on how many) and will apply a vertical scrollbar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is looking good and pretty close to completion!
I would recommend getting started on the React implementation (by linking the repos) while you finalize this. You might actually find that some CSS changes need to be made as you're working on React.
@mayank99 @veekeys @gretanausedaite I think all the comments should be resolved now, please take a look and let me know if there is still something that needs to be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 (unless we need some changes for React)
For some reason, the default color picker tests keep failing (despite no visual differences), so try re-running and/or updating images just in case.
Added basic and advanced color picker.