Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a general-purpose curve vector clipper #353

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

saeeedtorabi
Copy link
Contributor

Also fixed bunch of formatting, docs, and typos.

Also fixed bunch of formatting, docs, and typos.
Copy link
Member

@dassaf4 dassaf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have suggestions to improve doc and tests.

iModelCore/GeomLibs/PublicAPI/Geom/CurveDetails.h Outdated Show resolved Hide resolved
iModelCore/GeomLibs/PublicAPI/Geom/CurveVector.h Outdated Show resolved Hide resolved
iModelCore/GeomLibs/PublicAPI/Geom/ClipPlaneSet.h Outdated Show resolved Hide resolved
iModelCore/GeomLibs/PublicAPI/Geom/ClipPlaneSet.h Outdated Show resolved Hide resolved
iModelCore/GeomLibs/PublicAPI/Geom/ClipPlaneSet.h Outdated Show resolved Hide resolved
iModelCore/GeomLibs/PublicAPI/Geom/ClipPlaneSet.h Outdated Show resolved Hide resolved
iModelCore/GeomLibs/PublicAPI/Geom/ClipPlaneSet.h Outdated Show resolved Hide resolved
Copy link
Member

@dassaf4 dassaf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good!

@saeeedtorabi saeeedtorabi merged commit 29365d4 into main Jul 19, 2023
@saeeedtorabi saeeedtorabi deleted the saeed-torabi/ClipCurveVector branch July 19, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants