Added Ray3d.intersectWithTriangle #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saeeedtorabi
commented
Apr 14, 2023
saeeedtorabi
commented
- This new method makes ray-triangle intersection speed 2-3 times faster
- Added few other new APIs
- Added lots of accuracy and performance tests
- This new method makes ray-triangle intersection speed 2-3 times faster - Added few other new APIs - Added lots of accuracy and performance tests
saeeedtorabi
commented
Apr 14, 2023
|
Consider introducing the new method, and contrasting it to similar existing methods, in NextVersion.md. When would someone want to use it over the existing methods, and when not? |
dassaf4
approved these changes
Apr 18, 2023
saeeedtorabi
commented
Apr 19, 2023
- This new method makes ray-triangle intersection speed 2-3 times faster - Added few other new APIs - Added lots of accuracy and performance tests
- also increased test coverage to 95%
…/github.com/iTwin/itwinjs-core into saeed-torabi/Geometry-intersectWithTriangle
dassaf4
approved these changes
Apr 21, 2023
ben-polinsky
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.