-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support snapping to elements inside orthogonal view attachments #5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e1f4eff.
bbastings
approved these changes
Jun 14, 2023
markschlosseratbentley
approved these changes
Jun 14, 2023
@ben-polinsky @MichaelBelousov transformer docs still breaking this PR. New error.
|
branch 'pmc/view-attachment-snap' of https://github.com/iTwin/itwinjs-core into pmc/view-attachment-snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5585.
Viewport.readPixels
will now include the Id of the view attachment, if any, from which the hit originated.HitDetail
can have aViewAttachmentHitInfo
which includes that view attachment Id along with (marked as@alpha
- for internal consumption only!) theViewport
used to render the attachment into the sheet view.ViewState.computeDisplayTransform
now accepts an optional view attachment Id, which a sheet will use to provide the transform from that attachment's model space to the sheet's model space.AccuSnap
will populate the SnapRequestProps using the view attachment's viewport if present, instead of the screen viewport.The inverted display transform is applied to hit points when making the request, and the display transform is applied to sprite and hit decoration locations.
I had to add yet another optional argument to
HitDetail
, which already took over a dozen arguments. I overloaded that constructor to take a single object and deprecated the old one.