Use package.json exports in Electron-auth #6739
Draft
+287
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A follow up PR from #6058 |
aruniverse
reviewed
May 21, 2024
| @@ -1,6 +1,8 @@ | |||
| { | |||
| "extends": "./node_modules/@itwin/build-tools/tsconfig-base.json", | |||
| "compilerOptions": { | |||
| "module": "ESNext", | |||
There was a problem hiding this comment.
can you look at seeing if applying these tsconfig settings would help:
"resolvePackageJsonExports": true /* Use the package.json 'exports' field when resolving package imports. */,
"resolvePackageJsonImports": true /* Use the package.json 'imports' field when resolving imports. */,
There was a problem hiding this comment.
No, it didn't work - typescript docs mentions they should already be enabled by default, because the moduleResolution in our tsconfig is Bundler
* Improved formatting and documentations of PolyfaceQuery.ts. * Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions and fixed tests accordingly. * Added md doc for polyface dihedral angles. * Improved tests.
…n` is not available (#6760)
Co-authored-by: Eric Paquet <EricPaquetB@users.noreply.github.com> Co-authored-by: pmconne <22944042+pmconne@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>
…d Profile Upgrades (#6692) Co-authored-by: Affan Khan <khanaffan@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>
Co-authored-by: = <andremig-bentley@users.noreply.github.com> Co-authored-by: danieliborra <107669762+danieliborra@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
Co-authored-by: Arun George <aruniverse@users.noreply.github.com>
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: affank <khanaffan@gmail.com>
Co-authored-by: mcote01 <mcote01@users.noreply.github.com>
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: Nam Le <50554904+hl662@users.noreply.github.com> Co-authored-by: Raphaël LEMIEUX <1904889+raplemie@users.noreply.github.com>
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>
|
/azp run iTwin.js |
|
Pull request contains merge conflicts. |
|
/azp run iTwin.js |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
@itwin/electron-authorizationto^0.19.2Rush build compiled successfully, but rush cover throws the following error in
core-full-stack-tests:Some important changes regarding
core-full-stack-tests:Updated tsconfig.json to include:
And also updated package.json to have a
type: modulefield.