Use package.json exports in Electron-auth #6739

hl662 · 2024-05-21T15:38:01Z

Update @itwin/electron-authorization to ^0.19.2
Rush build compiled successfully, but rush cover throws the following error in core-full-stack-tests:

Package subpath './Main' is not defined by "exports" in /Users/hoangnamle/Documents/itwinjs-core/full-stack-tests/core/node_modules/@itwin/electron-authorization/package.json imported from /Users/hoangnamle/Documents/itwinjs-core/full-stack-tests/core/lib/backend/backend.js
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './Main' is not defined by "exports" in /Users/hoangnamle/Documents/itwinjs-core/full-stack-tests/core/node_modules/@itwin/electron-authorization/package.json imported from /Users/hoangnamle/Documents/itwinjs-core/full-stack-tests/core/lib/backend/backend.js
    at exportsNotFound (node:internal/modules/esm/resolve:303:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:593:13)
    at packageResolve (node:internal/modules/esm/resolve:836:14)
    at moduleResolve (node:internal/modules/esm/resolve:910:20)
    at defaultResolve (node:internal/modules/esm/resolve:1130:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36)

Some important changes regarding core-full-stack-tests:
Updated tsconfig.json to include:

    "module": "ESNext",
    "moduleResolution": "Bundler",

And also updated package.json to have a type: module field.

…s to be module

hl662 · 2024-05-21T15:38:47Z

A follow up PR from #6058

aruniverse · 2024-05-21T15:40:29Z

full-stack-tests/core/tsconfig.json

@@ -1,6 +1,8 @@
 {
  "extends": "./node_modules/@itwin/build-tools/tsconfig-base.json",
  "compilerOptions": {
+    "module": "ESNext",


can you look at seeing if applying these tsconfig settings would help:

"resolvePackageJsonExports": true /* Use the package.json 'exports' field when resolving package imports. */, "resolvePackageJsonImports": true /* Use the package.json 'imports' field when resolving imports. */,

No, it didn't work - typescript docs mentions they should already be enabled by default, because the moduleResolution in our tsconfig is Bundler

* Improved formatting and documentations of PolyfaceQuery.ts. * Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions and fixed tests accordingly. * Added md doc for polyface dihedral angles. * Improved tests.

…adable (#6741)

…n` is not available (#6760)

Co-authored-by: Eric Paquet <EricPaquetB@users.noreply.github.com> Co-authored-by: pmconne <22944042+pmconne@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>

…d Profile Upgrades (#6692) Co-authored-by: Affan Khan <khanaffan@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>

Co-authored-by: = <andremig-bentley@users.noreply.github.com> Co-authored-by: danieliborra <107669762+danieliborra@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>

Co-authored-by: Arun George <aruniverse@users.noreply.github.com>

Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>

Co-authored-by: David Stradley <48810710+DStradley@users.noreply.github.com>

Co-authored-by: StefanApfel <71712332+StefanApfel-Bentley@users.noreply.github.com>

…ned where possible. (#6901)

…6893) Co-authored-by: andremig-bentley <andremig-bentley@users.noreply.github.com>

…noreply.github.com>' Changelogs

#6906) Co-authored-by: yato333 <yato333@users.noreply.github.com>

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>

Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>

…low (#6911) Co-authored-by: Mike Nguyen <MikeNBentley@users.noreply.github.com>

hl662 · 2024-07-03T15:50:30Z

Dunno what happened here, moving to a new PR #6931 and closing this one.

hl662 added 2 commits May 19, 2024 14:08

update packages

74312ea

Use exports defined in electron-authorization, change full-stack-test…

7251847

…s to be module

aruniverse reviewed May 21, 2024

View reviewed changes

aruniverse mentioned this pull request May 21, 2024

use latest electron auth client pkg that uses export map #6058

Closed

imodeljs-admin and others added 25 commits June 3, 2024 15:07

@bentley/imodeljs-native 4.7.7

0c2b897

4.7.0-dev.7

0abc622

Improve Accept-Encoding header parsing (#6738)

b4bb085

@bentley/imodeljs-native 4.7.8

f093e99

Fix PolyfaceAuxData index blocking flatbuffer format (#6726)

05f6d7d

Improved PolyfaceQuery.ts (#6725)

863961f

* Improved formatting and documentations of PolyfaceQuery.ts. * Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions and fixed tests accordingly. * Added md doc for polyface dihedral angles. * Improved tests.

Bump several dependencies for test and example code packages (#6740)

c519415

@bentley/imodeljs-native 4.7.9

11ba43b

4.7.0-dev.8

4e14a64

rename difference changes property (#6744)

22b49d6

@bentley/imodeljs-native 4.7.11

c31ce1a

Move a few of PolyfaceQuery functions around to make the code more re…

bafdc17

…adable (#6741)

4.7.0-dev.9

ee126e3

Fix failed HTTP RPC requests not being rejected if `X-Protocol-Versio…

1996837

…n` is not available (#6760)

Add tests and API for getListOfGCS (#6724)

3a8d99a

Co-authored-by: Eric Paquet <EricPaquetB@users.noreply.github.com> Co-authored-by: pmconne <22944042+pmconne@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>

@bentley/imodeljs-native 4.7.13

556f9f5

4.7.0-dev.10

41a7426

4.7.0-dev.11

2aa51c1

IndexedDB Tile Cache (#6720)

d436b20

Co-authored-by: = <andremig-bentley@users.noreply.github.com> Co-authored-by: danieliborra <107669762+danieliborra@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>

@bentley/imodeljs-native 4.7.15

7738e12

@bentley/imodeljs-native 4.7.16

15d0d7f

4.7.0-dev.12

0357d2b

update to latest reality-data-client pkg (#6766)

9cf0c5a

Co-authored-by: Arun George <aruniverse@users.noreply.github.com>

4.6.1 Changelogs

25acbeb

imodeljs-admin and others added 28 commits July 2, 2024 11:44

4.8.0-dev.11

2c46bab

Add ConflictingLocksError class (#6852)

8f72937

Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>

@bentley/imodeljs-native 4.8.11

e35a945

4.8.0-dev.12

083a505

Add support for Electron 31 (#6823)

b687cc4

Reenable iOS backend unit tests (#6892)

aaa7093

@bentley/imodeljs-native 4.8.12

e2c8af8

Fix new tiles not updating planar clip mask immediately (#6894)

069e94a

Co-authored-by: David Stradley <48810710+DStradley@users.noreply.github.com>

4.8.0-dev.13

9149b78

Various Schema Editing additions (#6878)

dad6259

Co-authored-by: StefanApfel <71712332+StefanApfel-Bentley@users.noreply.github.com>

Within changeSummaryManager, try to rely on having an authClient defi…

be9909f

…ned where possible. (#6901)

4.8.0-dev.14

60290f5

Add iTwinJS and Tile Version Tracking to Graphics Service Requests (#…

876acf6

…6893) Co-authored-by: andremig-bentley <andremig-bentley@users.noreply.github.com>

4.7.3 Changelogs

827e16c

4.8.0-dev.15

00bb879

esm support in @itwin/ecschema-metadata (#6900)

44fa4b9

$'Undo Bad (#6908)Co-authored-by: Daniel Rodriguez <DanRod1999@users.…

d248346

…noreply.github.com>' Changelogs

4.8.0-dev.16

5c27602

Presentation: Add ability to customize subject ID for ruleset embedder (

e7d3ed0

#6906) Co-authored-by: yato333 <yato333@users.noreply.github.com>

Reinstate ecschema-metadata clean script (#6914)

35d976c

Update changeset when watchForChanges enabled (#6916)

869af50

Define policy for internal APIs (#6828)

63e8004

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>

@bentley/imodeljs-native 4.8.16

384e4de

Load all subcategories when creating a default view. (#6882)

0554544

Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>

4.8.0-dev.17

f5e2778

Add ListenerType helper (#6915)

7526250

Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>

@bentley/imodeljs-native 4.8.17

aede36b

Fix Incorrect Commit Message when Manually run Finalize Release Workf…

28253ac

…low (#6911) Co-authored-by: Mike Nguyen <MikeNBentley@users.noreply.github.com>

hl662 closed this Jul 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use package.json exports in Electron-auth #6739

Use package.json exports in Electron-auth #6739

hl662 commented May 21, 2024 •

edited

Loading

hl662 commented May 21, 2024

aruniverse May 21, 2024

hl662 May 21, 2024

hl662 commented Jul 3, 2024 •

edited

Loading

Use package.json exports in Electron-auth #6739

Use package.json exports in Electron-auth #6739

Conversation

hl662 commented May 21, 2024 • edited Loading

hl662 commented May 21, 2024

aruniverse May 21, 2024

Choose a reason for hiding this comment

hl662 May 21, 2024

Choose a reason for hiding this comment

hl662 commented Jul 3, 2024 • edited Loading

hl662 commented May 21, 2024 •

edited

Loading

hl662 commented Jul 3, 2024 •

edited

Loading