use latest electron auth client pkg that uses export map #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick4598
approved these changes
Oct 3, 2023
…ort() which is available in all CommonJS modules
|
used https://twitter.com/wesbos/status/1615738911380078592 to help with rewriting esm import |
|
rush cover locally failing on trying to resolve export map subpath which does exist: |
|
/azp run iTwin.js |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run iTwin.js Docs - YAML |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run iTwin.js Integration - GitHub |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
abandoning in favor of #6739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itwin/electron-authoorization@0.15 supports package.json export map
Update to use the following recommended tsconfigs:
Frontend:
ESNext
Bundler
Backend:
NodeNext
NodeNext
Everything should compile fine; I will note, vscode intellisense will still complain about being unable to resolve / traverse the fields from the export map