Updating TS version, ensuring packages work with node 12 and 16 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animagne
approved these changes
Jul 14, 2022
| @@ -127,3 +128,7 @@ export async function uploadToUrl( | |||
| headers, | |||
| }); | |||
| } | |||
|
|
|||
| export function getRandomString(): string { | |||
There was a problem hiding this comment.
Should add comment that this should be replaced by randomUUID() once we drop support for node.js 12/14.
…p support for Node 12.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
fsmethods that are unsupported in Node 12Note: Ideally in pipelines we should specify to use the latest release of a major LTS version (
16.xinstead of16.15.0) to use the release with latest security fixes. This is not the case now as the latest release of Node 16 includes npm version which in combination with that Node version produces build warnings on Windows:Link to GitHub issue for npm/cli
None of the workarounds seem applicable for use in pipelines.
Note: I have disabled frontend integration tests on Node 12 builds because they consume time and resources and they also run in browser. There is no need to test if tests infrastructure works on different Node versions.