Add listeners to other quantityFormatter events. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-gagnon
requested review from
a team,
simnorm and
bsy-nicholasw
as code owners
aruniverse
approved these changes
Nov 1, 2022
MindaugasButkus
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Setup DefaultTree for TreeView: (#321) Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * Bump versions [skip ci] * Insights update oclca (#317) * insights client 0.3.0 update * lint fix * rush change * Update common/changes/@itwin/one-click-lca-react/insights-update-oclca_2022-08-31-11-10.json make change type minor instead of patch Co-authored-by: Guillar1 <Guillar1@users.noreply.github.com> * fix * changes * falsy to truthy * rush install Co-authored-by: RytisSapka <rytis.sapka@users.noreply.github.com> Co-authored-by: Guillar1 <Guillar1@users.noreply.github.com> * [Grouping & Mapping] Group Extension (#297) Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * added peer dependencies to one click lca widget (#324) * added peer dependencies * bumped down version and removed unneecessary peers * rush change * Deleted unnecessary files * rerun test * [G&M] Context Custom UI (#322) * refactor add/modify group * fix sub menu on modify * add validation to manual query * add callback for extensions * fix icon type * add extendsDefault argument * merge * some merge conflicts * extension add on * rename extension argument * refactor manual * refactor search group creation * add radio tiles back in group creation page * dropdown style * remove experimental ui * fix bug and formatting * rush change * merge * update extension documentation * custom ui provider rename and default config * rush change * fix merge misses * description words choice * fix comments * fix css naming consistency * fix comments * fix comments * fix custom providers display label * fix linter * fix comments * some eslint exploration * add context UI provider and callback * add tests * fix import typo * fix comments * UI provider naming changes * merge * merge * add test for group list page * rename extensible UI to customUI * name changes * groupUI test * rename * GroupingMappingCustomUI test with default setting * remote unused package * naming and comment fix * fix comment * add props to context custom UI * fix comments * rush change * rush update * update documentation * fix comments * rush update Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> * [measure-tools] support global origin (#325) Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * Bump versions [skip ci] * [Grouping&Mapping] Properties Refactor (#318) * Bump versions [skip ci] * [ReportingWidgets] Fixed text overflow (#327) * Bump versions [skip ci] * Infrastructure Iot - Improved view zoom behavior (#331) * Updated view zoom behaviour when clicking on sensor markers * Fixed formatting in comments * Added .editorconfig file * Added change file Co-authored-by: Anton Ivanov <10566684+antonai@users.noreply.github.com> * Mapping formula fix (#332) * fix formula interpreter * changelog * lint fix * [G&M] Grouping Mapping Widget UI Tests (#329) * use absolute path to fix npm publish note * add grouping custom UI test * add context custom ui test suite * fix comments and add test * merge * resolve comments Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> * [G&M] Fixed key issue (#333) * Task/add formatter tests (#328) * Add launch config to properly debug tests in measure-tools. * Add unit tests for FormatterUtils. Changed minute/second symbol to match the one used in IModelApp.quantityFormatter * Rush change * Bump versions [skip ci] * support customizing the measure tools widget placement in the MeasureToolsUiProvider (#334) Co-authored-by: Jason Crow <25822334+jason-crow@users.noreply.github.com> * Bump versions [skip ci] * Datasets can be updated in the Reports page. Reports tiles are selectable (#326) * Datasets can be updated in the Reports page. Reports tiles are now selectable. Search button moved to the right * comment-fixes * Lint error fixed * Lint errors for UI fixed. PR comments fixed. Each extraction state moved to separate folder * Failing unit test fixed * Formatting fixed * Comments fixed. Extraction status moved to HorizontalTile * Failing test fixed * Pull request comments fix * ReportHorizontalTileProps interface extended. Indentation fixed * Missing return types and voids added * PR comments fix * Listeners are removed instead of cleared. Bug fixed with multiple job status requests. * retrigger tests * test timeout increased * testTimeout is increased in config file, as changing in single test is not working * rush update * package.json sort * Povilas/querybuilder remove query join duplication (#335) * Remove query duplication on joins * change log * Fix rush lint errors, PR comment fixes * PR comment fixes * change readme * rush update * signin fix * [measurement-tools] Hide Measurement Tools from toolbars when view is a sheet view. (#336) * Doesn't show Measurement Tools if the view is a sheet view. * Rush change. * WIP - pushing a fix that isn't work so Joe can help investigage * Removed clear measurements event checks in the incorrect isHidden code * Accidentally removed comma * Added sheet vs drawing check to clear measurments btn visibility * update isHidden logic for clear measure tool, update appui-abstract import Co-authored-by: Jason Crow <25822334+jason-crow@users.noreply.github.com> * Bump versions [skip ci] * test revision * template menu reorganization * label page rearanged * max width for title, dev insights client * lint fixes (only hook dependencies left) * Added report table selector component * rush change * readme info on setup * remove dev from clients * refresh after deletion, handle no reportMappings * first Mindaugas comment batch fix * prefix prop to change environment, insights client update * first Guillermo comment batch fix, test temporary fix * mindaugas second comment batch fix * Fix query builder cross references in query (#340) * Fix query builder cross references in query * Change log * PR comment fixes * PR fixes * [Grouping&Mapping] Group Properties Fixes (#342) * Bump versions [skip ci] * Don't show perpendicular tool when viewing a drawing (#338) * [Grouping&Mapping] Added coverage script (#343) * Bump versions [skip ci] * add insights client * update label with new reportid fix * eport modal bug fix, export button in main page, lint fixes * mindaugas comment batch fix * Add listeners to other quantityFormatter events. (#337) * Add listeners to other quantityFormatter events. * Rush change * Bump versions [skip ci] * Made black box around group color narrower (#323) * PR comment batch fix * fix bug where opening template would deselect it * remove reports modification * small fixes * low effort changes suggested by QA * Update ExportModal.tsx * test fix * Povilas/transfer properties to where clause (#344) * test utils * rename label name * label to assembly in UI * more tests * quick rename * Removed noop (#347) * tests * fixed dependency that was making other project fail * More noop removal (#348) * finished template tests * label action tests * PR comment fixes * label action tests * modal tests * lint fixes * fix warnings * fix dropbox not resetting * move the act on clicks to util function * small fixes * long line fix * delete empty lines * pr fixes * lil fix * rename * increase timeout --------- Co-authored-by: Jay Patel <54871480+pateljay1397@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com> Co-authored-by: RytisSapka <rytis.sapka@users.noreply.github.com> Co-authored-by: Guillar1 <Guillar1@users.noreply.github.com> Co-authored-by: Helen Zhou <88792140+bingjiez@users.noreply.github.com> Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> Co-authored-by: Alexandre.Gagnon <3418768+a-gagnon@users.noreply.github.com> Co-authored-by: Anton Ivanov <anton.aleks.ivanov@gmail.com> Co-authored-by: Anton Ivanov <10566684+antonai@users.noreply.github.com> Co-authored-by: Jason Crow <jason.crow@bentley.com> Co-authored-by: Jason Crow <25822334+jason-crow@users.noreply.github.com> Co-authored-by: Simonas-A <74193579+Simonas-A@users.noreply.github.com> Co-authored-by: 315salzaz <55460518+315salzaz@users.noreply.github.com> Co-authored-by: Cortney Smith <68698144+cortneysmithbentley@users.noreply.github.com> Co-authored-by: arinsasmal <87046458+arinsasmal@users.noreply.github.com>
MindaugasButkus
added a commit
that referenced
this pull request
Mar 15, 2023
* EC3-widget-react (#320) * initial commit for ec3 widget * groups loading and saving fixed * Dropdown tile created for pairs table * string and numerical columns separated. UI improved * EC3 widget improved. Template saving fixed * custom label added. Field validation added, fixed group saving * searching added for templates * unused variables and references removed * material selections are unique. TemplateMenu buttons moved down. Naming changed * variables and labels renamed according to requirements. Warnings are being fixed * table index error fixed. Save and cancel icons added * files were organized * configuration so tests can run and everything builds successfully * report dropdown test added * Templates table changed * more tests added, mapping fetch refactored * Redundant files deleted * Minor code style changes. Unnecessary comments removed * renamed ec3-widget to ec3-widget-react. Refactored tests. Removed unused packages. Added license and readme * Element styles fixed. Unnecessary style files deleted * EC3 configuration client added. Configuration properties renamed * EC3 jobs client added * EC3 job client added. 404 response for getConfigurations is handled. * Unecessary imports removed * Icons removed from configuration menu. Report selection is now searchable. Delete button moved. * Saving button disabled when Label is not configured. ReportTable dropdown is now searchable. * pnpm-lock updated * pnpm update * pnpm-lock update * pnpm update * Remove project fetch * Add EC3 OIDC auth implmenentation * Ec3 progress (#366) * Setup DefaultTree for TreeView: (#321) Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * Bump versions [skip ci] * Insights update oclca (#317) * insights client 0.3.0 update * lint fix * rush change * Update common/changes/@itwin/one-click-lca-react/insights-update-oclca_2022-08-31-11-10.json make change type minor instead of patch Co-authored-by: Guillar1 <Guillar1@users.noreply.github.com> * fix * changes * falsy to truthy * rush install Co-authored-by: RytisSapka <rytis.sapka@users.noreply.github.com> Co-authored-by: Guillar1 <Guillar1@users.noreply.github.com> * [Grouping & Mapping] Group Extension (#297) Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * added peer dependencies to one click lca widget (#324) * added peer dependencies * bumped down version and removed unneecessary peers * rush change * Deleted unnecessary files * rerun test * [G&M] Context Custom UI (#322) * refactor add/modify group * fix sub menu on modify * add validation to manual query * add callback for extensions * fix icon type * add extendsDefault argument * merge * some merge conflicts * extension add on * rename extension argument * refactor manual * refactor search group creation * add radio tiles back in group creation page * dropdown style * remove experimental ui * fix bug and formatting * rush change * merge * update extension documentation * custom ui provider rename and default config * rush change * fix merge misses * description words choice * fix comments * fix css naming consistency * fix comments * fix comments * fix custom providers display label * fix linter * fix comments * some eslint exploration * add context UI provider and callback * add tests * fix import typo * fix comments * UI provider naming changes * merge * merge * add test for group list page * rename extensible UI to customUI * name changes * groupUI test * rename * GroupingMappingCustomUI test with default setting * remote unused package * naming and comment fix * fix comment * add props to context custom UI * fix comments * rush change * rush update * update documentation * fix comments * rush update Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> * [measure-tools] support global origin (#325) Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * Bump versions [skip ci] * [Grouping&Mapping] Properties Refactor (#318) * Bump versions [skip ci] * [ReportingWidgets] Fixed text overflow (#327) * Bump versions [skip ci] * Infrastructure Iot - Improved view zoom behavior (#331) * Updated view zoom behaviour when clicking on sensor markers * Fixed formatting in comments * Added .editorconfig file * Added change file Co-authored-by: Anton Ivanov <10566684+antonai@users.noreply.github.com> * Mapping formula fix (#332) * fix formula interpreter * changelog * lint fix * [G&M] Grouping Mapping Widget UI Tests (#329) * use absolute path to fix npm publish note * add grouping custom UI test * add context custom ui test suite * fix comments and add test * merge * resolve comments Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> * [G&M] Fixed key issue (#333) * Task/add formatter tests (#328) * Add launch config to properly debug tests in measure-tools. * Add unit tests for FormatterUtils. Changed minute/second symbol to match the one used in IModelApp.quantityFormatter * Rush change * Bump versions [skip ci] * support customizing the measure tools widget placement in the MeasureToolsUiProvider (#334) Co-authored-by: Jason Crow <25822334+jason-crow@users.noreply.github.com> * Bump versions [skip ci] * Datasets can be updated in the Reports page. Reports tiles are selectable (#326) * Datasets can be updated in the Reports page. Reports tiles are now selectable. Search button moved to the right * comment-fixes * Lint error fixed * Lint errors for UI fixed. PR comments fixed. Each extraction state moved to separate folder * Failing unit test fixed * Formatting fixed * Comments fixed. Extraction status moved to HorizontalTile * Failing test fixed * Pull request comments fix * ReportHorizontalTileProps interface extended. Indentation fixed * Missing return types and voids added * PR comments fix * Listeners are removed instead of cleared. Bug fixed with multiple job status requests. * retrigger tests * test timeout increased * testTimeout is increased in config file, as changing in single test is not working * rush update * package.json sort * Povilas/querybuilder remove query join duplication (#335) * Remove query duplication on joins * change log * Fix rush lint errors, PR comment fixes * PR comment fixes * change readme * rush update * signin fix * [measurement-tools] Hide Measurement Tools from toolbars when view is a sheet view. (#336) * Doesn't show Measurement Tools if the view is a sheet view. * Rush change. * WIP - pushing a fix that isn't work so Joe can help investigage * Removed clear measurements event checks in the incorrect isHidden code * Accidentally removed comma * Added sheet vs drawing check to clear measurments btn visibility * update isHidden logic for clear measure tool, update appui-abstract import Co-authored-by: Jason Crow <25822334+jason-crow@users.noreply.github.com> * Bump versions [skip ci] * test revision * template menu reorganization * label page rearanged * max width for title, dev insights client * lint fixes (only hook dependencies left) * Added report table selector component * rush change * readme info on setup * remove dev from clients * refresh after deletion, handle no reportMappings * first Mindaugas comment batch fix * prefix prop to change environment, insights client update * first Guillermo comment batch fix, test temporary fix * mindaugas second comment batch fix * Fix query builder cross references in query (#340) * Fix query builder cross references in query * Change log * PR comment fixes * PR fixes * [Grouping&Mapping] Group Properties Fixes (#342) * Bump versions [skip ci] * Don't show perpendicular tool when viewing a drawing (#338) * [Grouping&Mapping] Added coverage script (#343) * Bump versions [skip ci] * add insights client * update label with new reportid fix * eport modal bug fix, export button in main page, lint fixes * mindaugas comment batch fix * Add listeners to other quantityFormatter events. (#337) * Add listeners to other quantityFormatter events. * Rush change * Bump versions [skip ci] * Made black box around group color narrower (#323) * PR comment batch fix * fix bug where opening template would deselect it * remove reports modification * small fixes * low effort changes suggested by QA * Update ExportModal.tsx * test fix * Povilas/transfer properties to where clause (#344) * test utils * rename label name * label to assembly in UI * more tests * quick rename * Removed noop (#347) * tests * fixed dependency that was making other project fail * More noop removal (#348) * finished template tests * label action tests * PR comment fixes * label action tests * modal tests * lint fixes * fix warnings * fix dropbox not resetting * move the act on clicks to util function * small fixes * long line fix * delete empty lines * pr fixes * lil fix * rename * increase timeout --------- Co-authored-by: Jay Patel <54871480+pateljay1397@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com> Co-authored-by: RytisSapka <rytis.sapka@users.noreply.github.com> Co-authored-by: Guillar1 <Guillar1@users.noreply.github.com> Co-authored-by: Helen Zhou <88792140+bingjiez@users.noreply.github.com> Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> Co-authored-by: Alexandre.Gagnon <3418768+a-gagnon@users.noreply.github.com> Co-authored-by: Anton Ivanov <anton.aleks.ivanov@gmail.com> Co-authored-by: Anton Ivanov <10566684+antonai@users.noreply.github.com> Co-authored-by: Jason Crow <jason.crow@bentley.com> Co-authored-by: Jason Crow <25822334+jason-crow@users.noreply.github.com> Co-authored-by: Simonas-A <74193579+Simonas-A@users.noreply.github.com> Co-authored-by: 315salzaz <55460518+315salzaz@users.noreply.github.com> Co-authored-by: Cortney Smith <68698144+cortneysmithbentley@users.noreply.github.com> Co-authored-by: arinsasmal <87046458+arinsasmal@users.noreply.github.com> * rush update * merge some more from master * merge master some more * merge ec3 fork (#372) * rush update * package.json sort * change readme * rush update * signin fix * test revision * template menu reorganization * label page rearanged * max width for title, dev insights client * lint fixes (only hook dependencies left) * Added report table selector component * rush change * readme info on setup * remove dev from clients * refresh after deletion, handle no reportMappings * first Mindaugas comment batch fix * prefix prop to change environment, insights client update * first Guillermo comment batch fix, test temporary fix * mindaugas second comment batch fix * add insights client * update label with new reportid fix * eport modal bug fix, export button in main page, lint fixes * mindaugas comment batch fix * PR comment batch fix * fix bug where opening template would deselect it * remove reports modification * small fixes * low effort changes suggested by QA * Update ExportModal.tsx * test fix * test utils * rename label name * label to assembly in UI * more tests * quick rename * tests * fixed dependency that was making other project fail * finished template tests * label action tests * PR comment fixes * label action tests * modal tests * lint fixes * fix warnings * fix dropbox not resetting * move the act on clicks to util function * small fixes * long line fix * delete empty lines * pr fixes * lil fix * rename * increase timeout --------- Co-authored-by: RytisSapka <107986502+RytisSapka@users.noreply.github.com> * merge * comments * no-verify * lint * lock merge * codeowners formatting revert --------- Co-authored-by: Simonas-A <74193579+Simonas-A@users.noreply.github.com> Co-authored-by: Raimondas Rimkus <3480123+rkkr@users.noreply.github.com> Co-authored-by: RytisSapka <107986502+RytisSapka@users.noreply.github.com> Co-authored-by: Jay Patel <54871480+pateljay1397@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com> Co-authored-by: RytisSapka <rytis.sapka@users.noreply.github.com> Co-authored-by: Guillar1 <Guillar1@users.noreply.github.com> Co-authored-by: Helen Zhou <88792140+bingjiez@users.noreply.github.com> Co-authored-by: bingjiez <bingjiez@users.noreply.github.com> Co-authored-by: Alexandre.Gagnon <3418768+a-gagnon@users.noreply.github.com> Co-authored-by: Anton Ivanov <anton.aleks.ivanov@gmail.com> Co-authored-by: Anton Ivanov <10566684+antonai@users.noreply.github.com> Co-authored-by: Jason Crow <jason.crow@bentley.com> Co-authored-by: Jason Crow <25822334+jason-crow@users.noreply.github.com> Co-authored-by: 315salzaz <55460518+315salzaz@users.noreply.github.com> Co-authored-by: Cortney Smith <68698144+cortneysmithbentley@users.noreply.github.com> Co-authored-by: arinsasmal <87046458+arinsasmal@users.noreply.github.com> Co-authored-by: arnobmallickbsw <Arnob.Mallick@bentley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add listeners to
onQuantityFormatsChangedandonUnitsProviderChangedfromIModelApp.quantityFormatterto make measurements are always in synch with the current units overrides.