Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Illegal constructor in Safari on desktop #55

Open
JoinThisBand opened this issue Nov 24, 2020 · 13 comments
Open

TypeError: Illegal constructor in Safari on desktop #55

JoinThisBand opened this issue Nov 24, 2020 · 13 comments
Assignees

Comments

@JoinThisBand
Copy link

In Safari on desktop an Illegal constructor error is thrown, which prevents the menu from working:

Screenshot 2020-11-24 at 18 01 02

All of your demos seem to be affected - happy to help with any further information.

Thanks

@msalihaltun
Copy link
Contributor

I think this issue is caused by the usage of custom elements. I'm not sure we can polyfill it in a simple way, maybe we can use this polyfill but we need to be aware of this section in their README as we are using constructors (this is the reason it might be complicated to go for a polyfill solution?).

@lbakke
Copy link

lbakke commented Feb 24, 2021

I'm also getting this issue in Electron.

@ugurdogrusoz
Copy link
Contributor

@ClientsideDesign @lbakke unfortunately we don't have resources to work on this at the moment. Feel free to make a patch and issue a PR on the unstable branch if you like.

@lbakke
Copy link

lbakke commented Feb 24, 2021

ok, no problem. @ugurdogrusoz I see that you're also involved with development for cytoscape-edge-editing, could you tell me if you can use edge-editing in any extent without the use of context-menu's in the cytoscape graph?

@ugurdogrusoz
Copy link
Contributor

@lbakke in fact none of our extensions depend on each other and all should be compatible with our knowledge. Enjoy! :)

@lbakke
Copy link

lbakke commented Feb 24, 2021

Okay, thank you! However when I try using edge-editing with the default parameters, right-clicking on an edge produces the error "contextMenus is not a function" which is why I thought it context-menu was necessary in order to use edge-editing. Is there a way to add bend points or remove them without using context-menu?

@ugurdogrusoz
Copy link
Contributor

You are right I completely forgot that we need the context menus to facilitate adding and removing bend / control points.

@msalihaltun
Copy link
Contributor

Can confirm that this issue is still persistent with latest version of Safari.

@matthughes
Copy link

Can someone point to the real source code of where this is blowing up? From what I gather, Safari supports custom elements, but doesn't support overriding existing elements (e.g., input, select). Is this project trying to override a built-in element or a custom one?

@matthughes
Copy link

And does anyone have a good way to check for this support so we can at least show the graph without the context menus. Otherwise the whole page blows up.

@JoinThisBand
Copy link
Author

@matthughes - did you see the polyfill suggestion on here? Not tried it myself. danieldietrich/candid#17 (comment)

@sveinp
Copy link

sveinp commented Sep 1, 2022

The suggestion seems to work in our case at least.

@JoshuaeKaiser
Copy link

This

@matthughes - did you see the polyfill suggestion on here? Not tried it myself. danieldietrich/candid#17 (comment)

This worked for me also. Not ideal, but atleast its a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants