Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init PKG vocabulary/ontology. #29

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

mgskjaeveland
Copy link
Collaborator

Fixes #23

@github-actions
Copy link

Unit Test Results

5 tests   5 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 9bd459e.

@github-actions
Copy link

Coverage Report •
FileStmtsMissCoverMissing
TOTAL1331884% 
report-only-changed-files is enabled. No files were changed during this commit :)

@github-actions
Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

Copy link
Collaborator

@NoB0 NoB0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some clarification questions before making a decision.

@@ -0,0 +1,22 @@
@prefix pkg: <http://example.org/pkg/> .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it standard to use http://example.org/? Or can we use something for tailored for our application.

Copy link
Collaborator Author

@mgskjaeveland mgskjaeveland Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example.org|com|net is standard to use for examples, as this address is reserved for such things.

We should make an IRI where we can publish the vocabulary file. I have 2 suggestions:

  1. iai's webpage, e.g., https://iai.group/vocabulary/pkg
  2. use github's webpages feature for this project

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks for clearing this up.

@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .

<> rdf:type owl:Ontology .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification question, why use <> instead of pkg here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<> means "this", so it says that "this file is an ontology". Once we have settled on an IRI where we can publish the vocabulary we should set this to something fixed.

Copy link
Collaborator

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about one thing. Could you clarify it before a final code review?

pkg:Preference rdf:type owl:Class .

pkg:preference rdf:type owl:ObjectProperty ;
rdfs:domain owl:Thing ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the preference property belong to the class Thing? Is it because if a predicate in triple is preference then subject is a person and person is an instance of Thing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a predicate in triple is preference then subject is a person and person is an instance of Thing

No, just:

if a predicate in triple is preference then subject is an instance of Thing

Think of owl:Thing as not a thing in the natural language sense, but as "anything". An option would be to remove the statement "pkg:preference rdfs:domain owl:Thing " as it is really not a restriction. The purpose of the statement is to say that anything can have a preference.

If it is the case that only persons can state a preference, then we can decide to state that.

@WerLaj WerLaj self-requested a review August 30, 2023 08:19
Copy link
Collaborator

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoB0 NoB0 self-requested a review September 6, 2023 06:34
Copy link
Collaborator

@NoB0 NoB0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please create a follow-up issue to update the file once we choose a domain to host the ontology.

@mgskjaeveland mgskjaeveland merged commit bd2f6ab into main Sep 15, 2023
5 checks passed
@mgskjaeveland mgskjaeveland deleted the feature/rdf-vocabulary branch September 15, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an RDF vocabulary about preferences
3 participants