-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init PKG vocabulary/ontology. #29
Conversation
Coverage Report •
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some clarification questions before making a decision.
@@ -0,0 +1,22 @@ | |||
@prefix pkg: <http://example.org/pkg/> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it standard to use http://example.org/
? Or can we use something for tailored for our application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example.org|com|net is standard to use for examples, as this address is reserved for such things.
We should make an IRI where we can publish the vocabulary file. I have 2 suggestions:
- iai's webpage, e.g., https://iai.group/vocabulary/pkg
- use github's webpages feature for this project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks for clearing this up.
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
|
||
<> rdf:type owl:Ontology . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a clarification question, why use <>
instead of pkg
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<> means "this", so it says that "this file is an ontology". Once we have settled on an IRI where we can publish the vocabulary we should set this to something fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about one thing. Could you clarify it before a final code review?
pkg:Preference rdf:type owl:Class . | ||
|
||
pkg:preference rdf:type owl:ObjectProperty ; | ||
rdfs:domain owl:Thing ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the preference property belong to the class Thing? Is it because if a predicate in triple is preference then subject is a person and person is an instance of Thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a predicate in triple is preference then subject is a person and person is an instance of Thing
No, just:
if a predicate in triple is preference then subject is an instance of Thing
Think of owl:Thing as not a thing in the natural language sense, but as "anything". An option would be to remove the statement "pkg:preference rdfs:domain owl:Thing " as it is really not a restriction. The purpose of the statement is to say that anything can have a preference.
If it is the case that only persons can state a preference, then we can decide to state that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please create a follow-up issue to update the file once we choose a domain to host the ontology.
Fixes #23