Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in indices? #24

Closed
vgupta1 opened this issue Apr 18, 2014 · 12 comments
Closed

Possible bug in indices? #24

vgupta1 opened this issue Apr 18, 2014 · 12 comments

Comments

@vgupta1
Copy link
Collaborator

vgupta1 commented Apr 18, 2014

So i can't yet confirm if this is a real bug, or a problem in my own code, but in I keep getting an ERROR: BoundsError() thrown from

in generateCut at /Users/VGupta/.julia/v0.2/JuMPeR/src/oracle_poly.jl:261

I'm not sure what it could be. Reformulation works correctly. Any ideas?

VG

@IainNZ
Copy link
Owner

IainNZ commented Apr 18, 2014

You're definitely on master?

@vgupta1
Copy link
Collaborator Author

vgupta1 commented Apr 18, 2014

Yeah, just pulled again...


Vishal Gupta
PhD Candidate, 2014
Operations Research Center
Massachusetts Institute of Technology
www.mit.edu/~vgupta1/

On Thu, Apr 17, 2014 at 9:35 PM, Iain Dunning notifications@github.comwrote:

You're definitely on master?


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-40780073
.

IainNZ added a commit that referenced this issue Apr 18, 2014
@IainNZ
Copy link
Owner

IainNZ commented Apr 18, 2014

OK, can you pull and try again?

@vgupta1
Copy link
Collaborator Author

vgupta1 commented Apr 18, 2014

Nope... If it helps, the issue is that length(coeff_coeff) = 1, and where trying to access element 2.

@vgupta1
Copy link
Collaborator Author

vgupta1 commented Apr 18, 2014

So, for the moment, is the branch safe or broken?

@IainNZ IainNZ closed this as completed in 0bd4b43 Apr 18, 2014
@IainNZ
Copy link
Owner

IainNZ commented Apr 18, 2014

Ahh I missed the other one.
Not sure what you mean about the branch - I'm working on master.

@IainNZ
Copy link
Owner

IainNZ commented Apr 18, 2014

(well, fixing master)

@vgupta1
Copy link
Collaborator Author

vgupta1 commented Apr 18, 2014

By branch i meant master.... :) is master safe?


Vishal Gupta
PhD Candidate, 2014
Operations Research Center
Massachusetts Institute of Technology
www.mit.edu/~vgupta1/

On Thu, Apr 17, 2014 at 9:55 PM, Iain Dunning notifications@github.comwrote:

Ahh I missed the other one.
Not sure what you mean about the branch - I'm working on master.


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-40780831
.

@IainNZ
Copy link
Owner

IainNZ commented Apr 18, 2014

I'll never put it in a state where the tests fail - doesn't mean there aren't bugs, but it should be monotonically improving

@vgupta1
Copy link
Collaborator Author

vgupta1 commented Apr 18, 2014

:) Thanks. you're a star. It seems to be running now. I'll let you know
if anything looks suspect.

VG


Vishal Gupta
PhD Candidate, 2014
Operations Research Center
Massachusetts Institute of Technology
www.mit.edu/~vgupta1/

On Thu, Apr 17, 2014 at 9:57 PM, Iain Dunning notifications@github.comwrote:

I'll never put it in a state where the tests fail - doesn't mean there
aren't bugs, but it should be monotonically improving


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-40780943
.

@IainNZ
Copy link
Owner

IainNZ commented Apr 18, 2014

Very keen to hear if the objectives match.
Although possibly all the bugs are now actually ironed out, I've got a plan for how to make sure the code is even more robust (haha)

@vgupta1
Copy link
Collaborator Author

vgupta1 commented Apr 18, 2014

The objectives do match for the robust model. (Sorry, I should have told you that earlier), and they match the nominal when Gamma =0.

This 2nd bug cropped up when using an affine formulation. Initial tests on the affine suggest taht they too do match!

The world is happiness and glee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants