Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making oracles even easier #31

Closed
IainNZ opened this issue Apr 28, 2014 · 0 comments · Fixed by #43
Closed

Making oracles even easier #31

IainNZ opened this issue Apr 28, 2014 · 0 comments · Fixed by #43

Comments

@IainNZ
Copy link
Owner

IainNZ commented Apr 28, 2014

Polyhedral oracle generateCut is looking very lean https://github.com/IainNZ/JuMPeR.jl/blob/master/src/oracle_poly.jl#L152-L189

  • 47 lines total
  • 18 actual lines (excluding whitespace, comments, the active cuts "hack", and debug lines)
  • 4 lines at the start at arguably the most awkward, and deal solely with handling the constraints that the oracle is reponsible for
  • 2 lines at end of awkwardness that requires "knowing" if you are in a IP or not
  • returns 1 and 0, the most common cases, look a bit odd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor oracle interface, now cleaner, simpler, and more powerful IainNZ/JuMPeR.jl
1 participant
@IainNZ