Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react intl #15

Merged
merged 23 commits into from
Apr 16, 2015
Merged

Add react intl #15

merged 23 commits into from
Apr 16, 2015

Conversation

iam4x
Copy link
Owner

@iam4x iam4x commented Apr 14, 2015

Implementation of react-intl

  • Implement react-intl client logic
  • Implement react-intl server logic
  • Switch locale
  • Split translations into chunks for lazy-loading
  • Add Spinner on changing lang req
  • Persist locale into cookie / localstorage
  • Clean the warnings from react-a11y
  • Fix actual tests
  • Add tests for react-intl
  • Fix different markup client / server
  • Fix .json webpack chunks
  • Update README

@iam4x iam4x added this to the 0.1.1 milestone Apr 14, 2015
@iam4x iam4x mentioned this pull request Apr 14, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-38.16%) to 56.89% when pulling bcffa10 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.16%) to 56.89% when pulling f7e9b94 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.16%) to 56.89% when pulling afa9aa1 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-37.64%) to 57.4% when pulling ae538e5 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.97%) to 56.07% when pulling 43ab68e on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.97%) to 56.07% when pulling 43ab68e on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-40.55%) to 54.49% when pulling 8e5e784 on add-react-intl into 0dd5229 on master.

@iam4x iam4x modified the milestones: 0.1.1, 0.2.0 Apr 15, 2015
@iam4x iam4x self-assigned this Apr 15, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-40.55%) to 54.49% when pulling c60b28f on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-41.74%) to 53.3% when pulling 638ba46 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-42.04%) to 53.01% when pulling 36785e5 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-15.81%) to 79.23% when pulling 8489677 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.1%) to 85.95% when pulling 369a260 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.63%) to 95.68% when pulling 30d19b5 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.63%) to 95.68% when pulling 963ced0 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.63%) to 95.68% when pulling 7b7cb72 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.63%) to 95.68% when pulling 7b7cb72 on add-react-intl into 0dd5229 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.63%) to 95.68% when pulling 7be046c on add-react-intl into 0dd5229 on master.

@iam4x
Copy link
Owner Author

iam4x commented Apr 16, 2015

It fixes also #14

@coveralls
Copy link

Coverage Status

Coverage increased (+0.63%) to 95.68% when pulling bbc4efe on add-react-intl into 1a3b90b on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.63%) to 95.68% when pulling ca07834 on add-react-intl into 1a3b90b on master.

iam4x pushed a commit that referenced this pull request Apr 16, 2015
@iam4x iam4x merged commit 3e7cf7d into master Apr 16, 2015
@dmitry
Copy link

dmitry commented Apr 16, 2015

Thank you for working on that!

Do you know some service, that helps to translate the keys and then export them into the intl format?
In our current projects I'm using webtranslateit.com and phraseapp.com, but they are not providing such export.
What kind of the workflow do you use to translate application when using intl? Just by hand?

@iam4x
Copy link
Owner Author

iam4x commented Apr 16, 2015

@dmitry I haven't used such services yet, what is output from them? a JSON / YAML?

@dmitry
Copy link

dmitry commented Apr 16, 2015

JSON or YAML can be exported. I know that it's easy to convert JSON/YAML to

{
  messages: JSON
}

But still, it nice to have a tool that will convert everything directly to intl.

When project grows, it's hard to translate everything as a end-to-end developer ;)

Anyway thank you for the answer!

@iam4x
Copy link
Owner Author

iam4x commented Apr 16, 2015

@dmitry You can have a script run before compiling for production or/and at first compilation on dev, look how I call webpack/utils/clean-dist.js into webpack/prod.config.js

It shouldn't be a big deal 👍

@iam4x iam4x deleted the add-react-intl branch April 17, 2015 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants