fix: preserve the type of failures that are instances of Error

[vecerek]

Fixes #12

[vecerek]

@iamchanii what does the following code mean:

if (Cause.isAnnotatedType(result.cause) && Cause.isFailType(result.cause.cause)) {
  throw result.cause.cause.error;
}

and how would I be able to return an annotated type as an alternative to this fix?

[iamchanii]

@iamchanii what does the following code mean:

if (Cause.isAnnotatedType(result.cause) && Cause.isFailType(result.cause.cause)) {
  throw result.cause.cause.error;
}

and how would I be able to return an annotated type as an alternative to this fix?

@vecerek At least when I implemented, Effect.runPromiseExit provided annotated exit.

EffectPrimitiveFailure {
  _tag: 'Failure',
  i0: {
    _tag: 'Annotated',
    cause: { _tag: 'Fail', error: [NotFound] },
    annotation: StackAnnotation {
      stack: [Object],
      seq: 1,
      [Symbol(@effect/io/Cause/StackAnnotation)]: Symbol(@effect/io/Cause/StackAnnotation)
    }
  },
  i1: undefined,
  i2: undefined,
  trace: undefined,
  [Symbol(@effect/io/Effect)]: { _R: [Function: _R], _E: [Function: _E], _A: [Function: _A] }
}

But now we got just Failed exit. so Cause.isAnnotatedType(...) condition is false.

EffectPrimitiveFailure {
  _tag: 'Failure',
  i0: {
    _tag: 'Fail',
    error: NotFound: User iamchanii2 not found
        at <anonymous> (/Users/iamchanii/dev/pothos-plugin-effect/examples/02-with-errors-plugin/src/GitHub.ts:51:63)
        at e (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/effect.ts:250:14)
        at cause (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/core.ts:683:16)
        at FiberRuntime.Failure (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/fiberRuntime.ts:1082:25)
        at <anonymous> (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/fiberRuntime.ts:1278:51)
        at onRun (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/supervisor.ts:227:12)
        at runLoop (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/fiberRuntime.ts:1276:32)
        at evaluateEffect (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/fiberRuntime.ts:846:29)
        at evaluateMessageWhileSuspended (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/fiberRuntime.ts:813:14)
        at drainQueueOnCurrentThread (/Users/iamchanii/dev/pothos-plugin-effect/node_modules/.pnpm/@effect+io@0.37.1/node_modules/@effect/io/src/internal/fiberRuntime.ts:569:18) {
      _tag: 'NotFound'
    }
  },
  i1: undefined,
  i2: undefined,
  trace: undefined,
  [Symbol(@effect/io/Effect)]: { _R: [Function: _R], _E: [Function: _E], _A: [Function: _A] }
}

It means Effect.runPromiseExit's internal implementation in @effect/io was changed from v0.30.0 to now.

[iamchanii]

result.cause.error could can be not an instance of Error. so it should be wraped by failErrorConstructor, effectOptions.defaultFailErrorConstructor or Error.

[vecerek]

I might be misunderstanding you but that's exactly the reason for which I'm also checking if result.cause.error instanceof Error in the above code. If it isn't, I want it to fall through and be handled by the throw logic below:

throw new (effect.failErrorConstructor ?? effectOptions?.defaultFailErrorConstructor ?? Error)(
  Cause.pretty(result.cause),
);

[iamchanii]

ahh yep. you're right.

[iamchanii]

fyi: there might be situated that result.cause is annotated, so I use Cause.unannotate a5c9a89

Ref: https://canary.discord.com/channels/795981131316985866/1141586320624468068