Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

effect dependency update #28

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Enalmada
Copy link
Contributor

In order to allow new users of effect to use this plugin while referring to latest effect documentation, dependency must be updated.

changes made for build:

  • update effect dependency to 2.2.2 (latest)
  • fix field-builder.ts file to use current effect api

changes made for tests to pass:

  • create src/tests/fixtures/prisma-client directory if it doesn't exist (generate will fail on clean system without this)
  • prisma generate before tests as they are a dependency of integrate-prisma.test.ts. test fail without this
  • fix [integrate-errors.test.ts to get effect dependencies from 'effect'
  • add "node_modules/@pothos/plugin-prisma" to tsconfig.json include so build can reference it

other:

  • gitignore intellij files under .idea/

Not done:

  • change peerDependencies version. I can't tell what version effect refactored away some of the api. Ideally the peerDependency would be update to the minimum.

Copy link
Owner

@iamchanii iamchanii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution 👍

@iamchanii iamchanii merged commit dfa509a into iamchanii:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants