forked from ericclemmons/react-resolver
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csp #2
Open
gilesbradshaw
wants to merge
89
commits into
iamdustan:master
Choose a base branch
from
gilesbradshaw:csp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Csp #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support contexts for easier integration with React Router
Fixed missing braces to import Resolver
Fix spelling + grammar in README.md
* 'master' of github.com:ericclemmons/react-resolver: Fix spelling + grammar in README.md
require react/lib/cloneWithProps directly instead of through addons
…it so that serer will render with errors indicated rather than just crashing out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not suggesting you take this as is - but this is where I am up to with CSP so PRed it in case you are interested to see - not re done any tests yet + not sure how it deals with error handling. My thought is that channels will be able to 'keep on giving' and are a more general case.
a channel would get plugged into createcontainer as ..