avoid specializing convert for Any result types
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specializing `convert(Result{Any, E}, x)` for every type of `x` can
incur substantial compilation overhead (not only on `convert` but also
on `Some`). This change avoids specializing in case of explicit `Any`
result type.
This is analogous to Julia Base where we have
```
convert(::Type{Any}, Core.@nospecialize x) = x
```
to avoid excessive specialization.
|
Superseded by #27 |
0x0f0f0f
added a commit
that referenced
this pull request
Jul 30, 2024
avoid specializing convert for Any result types (superseding #25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specializing
convert(Result{Any, E}, x)for every type ofxcan incur substantial compilation overhead (not only onconvertbut also onSome). This change avoids specializing in case of explicitAnyresult type.This is analogous to Julia Base where we have
to avoid excessive specialization.