Add a more thorough explanation of the .isValid function in the docs #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1859 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 181 181
Lines 2064 2064
Branches 537 537
=========================================
Hits 2064 2064 Continue to review full report at Codecov.
|
|
Looks nice, can you submit it to the doc website, please? |
iamkun
reviewed
Apr 21, 2022
| - Browser | ||
| - Non-strict check. | ||
|
|
||
| Only checks if the value can be `instanceof Date`. |
There was a problem hiding this comment.
to check if it could be parsed to a Date time, is it easy to understand?
There was a problem hiding this comment.
Yes, it is very clear. Just to get it straight, you'd prefer if I change this: ...value can be instanceof Date. to this: checks if value could be parsed to a Date time?
|
close dayjs/dayjs-website#71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.