Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update plugin to pass the proper rave parameters #6

Merged
merged 4 commits into from
Aug 13, 2019
Merged

update plugin to pass the proper rave parameters #6

merged 4 commits into from
Aug 13, 2019

Conversation

anjolabassey
Copy link
Contributor

  • update plugin to pass the proper rave parameters
  • implement same base url
  • update readme.md

iamraphson
iamraphson reviewed Aug 5, 2019
View reviewed changes
README.md Outdated
paymentOptions="card,barter,account,ussd"
hostedPayemt=1
customTitle="Testing title"
customLogo="https://www.freelogodesign.org/Content/img/logo-samples/bakary.png"
Copy link
Owner

@iamraphson iamraphson Aug 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customLogo is not compulsory so please kindly remove the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamraphson yes it is not compulsory, this is just a sample for users. same for the other parameters that are not compulsory but documented in the readme.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iamraphson bumping this up, thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@temiadesina no need for the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamraphson i've taken it out. kindly merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iamraphson please bumping this up, thanks!

@iamraphson iamraphson merged commit 8deebe5 into iamraphson:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@temiadesina temiadesina temiadesina left review comments

@iamraphson iamraphson iamraphson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anjolabassey @iamraphson @temiadesina