Fixes for u.ie9.js #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a problem evolved from `u.ie9.js`: `document.body` was not defined when the script was executed. But it is available after `DOMContentLoaded`. However, the user may add init handler with u(func) at any time. But the specialized class function have to be overridden *before* any handler is called. The ordered initializer list solves this problem.
|
Good catch. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
u.ie9.js,document.bodywas undefined at the time the script was executing, because the DOM was not fully loaded. My first attempt was to wrap the definition of the override methods inside aDOMContentLoadedevent listener, so the body would be available. But, it needed to execute before all other user defined init handlers (registered withu(func)). So I defined an ordered list of init handlers inu.js. Instead of binding them directly toDOMContentLoaded, the handlers are now added to the list and executed within a singleDOMContentLoadedlistener. This givesu.ie9.jsthe change to add its handler at the beginning of the list.Additionally, the index arguments of the iterator callbacks were missing.