FIX 403 Error #10
FIX 403 Error #10
Conversation
src/tokenGenerator.js
Outdated
| // config.set('TKK', TKK); | ||
| // } | ||
| // /* eslint-enable no-undef */ | ||
| // } |
There was a problem hiding this comment.
there is no point in keeping commented old code. either remove it or use as much as possible from old approach
|
As you can see I labelled it as WIP, later I will do code reformating, I am
waiting for confirmation from others.
…On Mon, Jul 22, 2019, 14:35 Vasyl Zuzyak ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/tokenGenerator.js
<#10 (comment)>
:
> }
+ // if (code) {
+ // eval(code[0]);
+ // /* eslint-disable no-undef */
+ // if (typeof TKK !== 'undefined') {
+ // window.TKK = TKK;
+ // config.set('TKK', TKK);
+ // }
+ // /* eslint-enable no-undef */
+ // }
there is no point in keeping commented old code. either remove it or as
much as possible from ol approach
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACOHNHSS2V42PTMDUDAZNMLQAV5PFANCNFSM4IFWPTXQ>
.
|
Long text wasn't translating. Fixed Url stays the same while switching to POST, actually should remove q parameter from url. Fixed
|
I think I've finished, just check both GET and POST requests. should work as intended. |
|
hey @k3rn31p4nic how about releasing new version with this change? |
|
Gonna do that after I test it with the application where I use it regularly to see if I need to do any changes before releasing. |
|
Some new issue Error while translating
{ HTTPError
at translate (/opt/translator/node_modules/@k3rn31p4nic/google-translate-api/src/index.js:143:19)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:182:7)
name: 'HTTPError',
statusCode: 429,
statusMessage: 'Too Many Requests' } |
|
Hi @k3rn31p4nic! do you have any news on your testing? a bit offtop: just noticed that this package does not have minimum required version of node to run. I made a quick walk through code and found edit: fixed typo |
Yeah, it works.
I'll set the node engine version and make a release soon. |
|
Released in v1.1.0 🎉 |
Same here, anyone fixed this ? |
Removed proxy support, as they make more complexity. Fixed token generator.
I am still testing, I haven't get any 403 error yet
Closes #7