Fix broken automated tests by syncing with exif-samples #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtiennePelletier
changed the title
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the automated tests that were broken primarily due to an out-of-sync dump file in the exif-samples repository. It ensures the commands used to run the tests in exifread are consistent with those in the exif-samples repository.
Please note that the tests in this PR will not pass until the following related PRs are merged:
PR #12 in exif-samples - to update the dump file and simplify future updates.
PR #173 and PR #196 - to fix issues in exifread when parsing HEIF files.
Additionally, I recommend including the CI maintenace changes from PR #195.
I have verified that all tests pass when these changes are merged in a separate branch: Successful test run.
I welcome any feedback or suggestions on these changes!
🐍 🤹♂️