-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to support p2wsh version bytes (with custom derivation path)? #351
Comments
Thanks for this. Sounds good, I'll look into including this in the next release, it's a good feature to have. |
Awesome, that would be super cool! Looking forward to it. Any timeline? I know estimates are the worst :) |
Any update on this? Thanks! |
I've implemented this but when I tried to import Zpub to electrum to test compatibility it gave an error This is Zpub for
Steps in electrum 3.3.8:
Can you please let me know the steps to import these extended keys to electrum so I can check address generation is consistent? Also I'm curious about your derivation path purpose being 48... where does that come from since the bips repository doesn't have a bip48? |
Electrum only allows multisig with 2 participants, and this tool only deals with 1 extended key, so I still have a problem of verifying this tool output with a third party tool. I was hoping to generate a 1-of-1 address and use the electrum value as an alternative / test / comparison for this tool. Any tips on how to use a third-party tool for verification / testing of this feature in the context of this tool? See TODOs in 5c203fa |
Awesome! Some potential test vectors you could include: Another way would be to confirm the output matches the workaround steps above (#351 (comment)). I just compiled your latest and confirm that worked, so that's exciting! Alternatively, this is also manual but could work?:
|
Decided to go with 1-of-1 multisig for these addresses. f7e9fdf - Generate addresses for P2WSH and P2WSH-P2SH |
I'm writing a guide for multi hardware wallet multisig, and right now the best option for that is (unfortunately) Electrum. I love this tool you've built, and I'd like to recommend incorporating it for generating one key of a multisig to keep offline as an emergency recovery option. As you may know, the extended pubkeys generated with this tool are not compatible with electrum's segwit multisig implementation :(
Here is the workaround I've come up with:
m/48'/1'/0'/2'
(for native segwit)This does work, but the UX is awful and the risk of mistakes for average users is high. Instead, I have to recommend they use regular old P2SH (with custom BIP32 derivation path
m/45'/0
). To clarify, I'm asking if you'd be open to adding the version bytes in SLIP-0032.If we want all our seeds to be BIP39 (best practice) we could recommend a user could just paste their BIP39 seed from this site into electrum and generate a Zpub/Vpub that way, but I'm worried about them then properly destroying the seed. Your site is easy enough for regular users to be able to run offline and delete afterwards.
It'd be great to also have an option for p2sh wrapped segwit (
p2wsh-p2sh
), but that's less important vs p2wsh. If you're open to it, the "Script Semantics" dropdown on the BIP141 tab is a nice UI option.Thanks!
The text was updated successfully, but these errors were encountered: