Add Nebulas (NAS) #314
Merged
Add Nebulas (NAS) #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test, eg https://github.com/iancoleman/bip39/blob/master/tests/spec/tests.js#L503-L509 How do you suggest I audit the new file nebulas.js which is over 40K lines long and contains minified js. Genuine question. |
|
@iancoleman test spec added Yeah. Reviewing minified code is impossible. I replaced nebulas.js with just part of it which is responsible for address generation, but it still big. You can audit uncompiled version. I was using this gulp recipe to build nebulas-account.js. Nebulas is not a bitcoin fork so it need to use separate library to create addresses as well as ethereumjs-util.js or bchaddrjs-0.2.1.js. |
|
Thanks for this, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Nebulas Network
Official website: https://nebulas.io
Slip0044 Index: 2718
Chain ID: 2718