Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToSnake not support string contains "." #16

Closed
jzlikewei opened this issue Sep 29, 2019 · 2 comments
Closed

ToSnake not support string contains "." #16

jzlikewei opened this issue Sep 29, 2019 · 2 comments

Comments

@jzlikewei
Copy link

ToSnake("AwesomeAcitvity.UserID") should be "awesome_acitvity.user_id" but not "awesome_acitvity._user_id"
@floydspace
Copy link
Contributor

Hey @jzlikewei, shouldn't it be awesome_acitvity_user_id?

@floydspace floydspace mentioned this issue Nov 4, 2019
Merged
@alock alock mentioned this issue Jan 13, 2020
Closed
@iancoleman
Copy link
Owner

See #17 test which fixes this in func TestToSnakeWithIgnore(t *testing.T)

strcase/snake_test.go

Line 78 in 4406733

{"AwesomeAcitvity.UserID", "awesome_acitvity.user_id","."},

Thanks @jzlikewei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iancoleman @floydspace @jzlikewei