-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some feature update #26
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've also removed "play" and "analysis" page as their functions are highly duplicated with "advanced" page. |
Thanks a lot! The support for promotions and gating is a really nice and very much needed addition. To review it in detail will take more time. One comment though regarding the extra pages. What you now renamed to the index page was the only page originally and only recently I added the additional pages. My main goal was to simplify the interface, since fairyground is currently the only real link I have from the official website to quickly try out live what Fairy-SF is about, so it should in my mind more or less just take selecting a variant to immediately start playing or analyzing. However, I did not want to drop the original layout, because I still found it useful for expert users. So to me it would still be important to somehow keep both target groups in mind. |
I continued to write some quick & dirty codes to add the following features based on previous changes:
The code is not in good quality and the features, I think, may be unnecessary for this simple demo. So if you don't like changes above, you can disapprove them :) . |
Thanks for all the additions. Are you planning to do further changes, or is this PR ready for review? |
Just to check back, are you planning to do any further changes to the PR and/or address my comments from above, or should I take over from here? |
demo: https://fairyground-new.vercel.app/
Minor changes:
Major changes
Minor updates are small improvements so they don't have bugs (At least I haven't experienced any bugs).
Major updates are large improvements that can create some hidden bugs or contain some not well-written codes. They need further maintaining.