Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git blame line check #1517

Merged
merged 4 commits into from
Jul 19, 2024
Merged

fix: git blame line check #1517

merged 4 commits into from
Jul 19, 2024

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Jul 17, 2024

Description:

Fix the line check for git blame results.

Related Issues:

N/A

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis
Copy link
Owner Author

Should add a unit test for this.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (163014e) to head (215bf3e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files          17       17           
  Lines        1057     1057           
=======================================
  Hits          823      823           
  Misses        171      171           
  Partials       63       63           
Files Coverage Δ
internal/walker/walker.go 59.32% <0.00%> (ø)

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis marked this pull request as ready for review July 19, 2024 05:48
@ianlewis ianlewis merged commit fcea64e into main Jul 19, 2024
14 of 15 checks passed
@ianlewis ianlewis deleted the blame-line-no-check branch July 19, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant