Support the arrow package #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI seems to have failed to install arrow. |
eitsupi
force-pushed
the
support-arrow
branch
from
79becd2
to
66b94b6
Compare
|
Thank you! I will take a closer look at this soon. |
ianmcook
force-pushed
the
support-arrow
branch
from
eee35b7
to
a6aa255
Compare
|
I migrated the CI to GitHub Actions, rebased your PR branch to re-run the checks, and merged your PR. I will make some additional changes in subsequent commits that will affect how tidyquery works with arrow. If any of these changes break your integration with prqlr, please let me know. Thanks! |
|
Thanks for working on that! |
|
I expanded the tests on Arrow objects in b97f4e2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this great package.
Since the package I recently created can be used with tidyquery1, I thought it would be even more wonderful to be able to support arrow here.
Please let me know if there is anything you think needs to be done to support arrow so I may work on it.
Close #16
Footnotes
https://eitsupi.github.io/prqlr/articles/prqlr.html#work-with-r-data-frame ↩