Don't supply unknown arguments to dplyr join functions #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've gotten stricter in dplyr 1.1.0
|
Thanks @lionel-! I will review and merge this soon and plan to submit an update to CRAN before mid-January |
|
Version 0.2.4 of tidyquery is now on CRAN. It contains these and some other changes for compatibility with dplyr 1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with dplyr 1.1.0 where the join functions are now stricter with unknown arguments instead of ignoring them.
I've also set
multiple = "all"to silence a new warning about multiple matches. That might need adjustment if that's not the expected behaviour.We plan to release dplyr on January 27. If possible, a pre-emptive fix release would be helpful to our release process. Thanks!