Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos for EC2 Image Builder #284

Merged
merged 3 commits into from
May 19, 2023
Merged

Fix typos for EC2 Image Builder #284

merged 3 commits into from
May 19, 2023

Conversation

darioackermann
Copy link
Contributor

Fixes #283

@darioackermann darioackermann changed the title Fix typos for EC2 Image Builder WIP: Fix typos for EC2 Image Builder Nov 28, 2022
@darioackermann darioackermann marked this pull request as draft November 28, 2022 19:10
@iann0036
Copy link
Owner

iann0036 commented Dec 5, 2022

Hey @darioackermann,

Thanks for the PR and sorry for the late response.

The Schedule fix is good, however the casing for AmiDistributionConfiguration should be correct as-is, per the docs. Let me know if you think otherwise.

@darioackermann
Copy link
Contributor Author

Yes, you're right. I realized that too and thus changed the PR back to WIP.
I think I've stumbled upon another typo, and I'll ping you for review once I've fixed this PR.

@darioackermann darioackermann marked this pull request as ready for review December 5, 2022 06:40
@darioackermann darioackermann changed the title WIP: Fix typos for EC2 Image Builder Fix typos for EC2 Image Builder Dec 5, 2022
@darioackermann
Copy link
Contributor Author

I think now we're good to go.
Thanks for providing former2, saved a lot of work for us <3

@iann0036 iann0036 merged commit 3697576 into iann0036:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iann0036 iann0036 iann0036 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creation for imageBuilder contains mistakes
2 participants
@darioackermann @iann0036