-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up to make building MacOS Package work... #77
Open
gutow
wants to merge
9
commits into
iansan5653:master
Choose a base branch
from
gutow:package
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−8
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d08ad36
Working Scrollable GUI for smaller screens
gutow 4fada59
Scrollable Interface with reasonable minimum window size.
gutow 3a7a862
MacOS specific opening of help and template files. Point to manual.md…
gutow 7b33bff
Add Linux compatibility to help and print buttons
gutow fe33e44
Fix damaged 150q pdf. Better file path building. Update requirements …
gutow a134473
Revert "Scrollable Interface with reasonable minimum window size."
gutow 3a6449f
Revert "Working Scrollable GUI for smaller screens"
gutow 22a6f20
remove offset answer testing finish scroll revert
gutow 7ddc5f7
change e-mail and repository in setup.py
gutow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import setuptools | ||
|
||
with open("readme.md", "r") as f: | ||
long_description = f.read() | ||
|
||
setuptools.setup( | ||
name="open-mcr", | ||
url = "https://github.com/iansan5653/open-mcr", | ||
version="1.3.0dev", | ||
description="Graphical tool for optical mark recognition for test scoring.", | ||
long_description=long_description, | ||
long_description_content_type="text/markdown", | ||
author="Ian Sanders", | ||
author_email="iansan5653@gmail.com", | ||
keywords="omr, optical-mark-recognition, open-educational-resources, " \ | ||
"exam-sheets, exam-scoring", | ||
license="GPL-3.0+", | ||
packages=setuptools.find_packages(exclude=("dist","build",)), | ||
data_files=[ | ||
('src/assets',['src/assets/icon.ico','src/assets/icon.svg', | ||
'src/assets/multiple_choice_sheet_75q.pdf', | ||
'src/assets/multiple_choice_sheet_75q.svg', | ||
'src/assets/multiple_choice_sheet_150q.pdf', | ||
'src/assets/multiple_choice_sheet_150q.svg', | ||
'src/assets/social.png', 'src/assets/wordmark.png', | ||
'src/assets/wordmark.svg', 'src/assets/manual.md', | ||
'src/assets/manual.pdf']) | ||
], | ||
include_package_data=True, | ||
install_requires=[ | ||
'PyInstaller>=4.6', | ||
'Pillow==9.2.0', | ||
'numpy==1.22.0', | ||
'opencv-python==4.5.4.60', | ||
'flake8==3.7.8', | ||
'yapf==0.28.0', | ||
'pytest==6.2.5', | ||
], | ||
classifiers=[ | ||
'Development Status :: 5 - Production/Stable', | ||
'Intended Audience :: Developers', | ||
'Intended Audience :: Education', | ||
'Intended Audience :: End Users/Desktop', | ||
'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)', | ||
'Programming Language :: Python :: 3', | ||
'Operating System :: OS Independent' | ||
] | ||
) |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
Last Name,First Name,Middle Name,Test Form Code,Student ID,Course ID,Source File,Q1,Q2,Q3,Q4,Q5 | ||
,,,,12345678,,a.jpg,A,B,B,D,E | ||
,,,,12334235,,b.jpg,A,,C,D,E | ||
,,,,12345678,,a.jpg,A,B,B,D,E |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
Last Name,First Name,Middle Name,Test Form Code,Student ID,Course ID,Source File,Total Score (%),Total Points,Q1,Q2,Q3,Q4,Q5,Q6,Q7,Q8,Q9,Q10,Q11,Q12,Q13,Q14,Q15,Q16,Q17,Q18,Q19,Q20,Q21,Q22,Q23,Q24,Q25,Q26,Q27,Q28,Q29,Q30,Q31,Q32,Q33,Q34,Q35,Q36,Q37,Q38,Q39,Q40,Q41,Q42,Q43,Q44,Q45,Q46,Q47,Q48,Q49,Q50,Q51,Q52,Q53,Q54,Q55,Q56,Q57,Q58,Q59,Q60,Q61,Q62,Q63,Q64,Q65,Q66,Q67,Q68,Q69,Q70,Q71,Q72,Q73,Q74,Q75,Q76,Q77,Q78,Q79,Q80,Q81,Q82,Q83,Q84,Q85,Q86,Q87,Q88,Q89,Q90,Q91,Q92,Q93,Q94,Q95,Q96,Q97,Q98,Q99,Q100,Q101,Q102,Q103,Q104,Q105,Q106,Q107,Q108,Q109,Q110,Q111,Q112,Q113,Q114,Q115,Q116,Q117,Q118,Q119,Q120,Q121,Q122,Q123,Q124,Q125,Q126,Q127,Q128,Q129,Q130,Q131,Q132,Q133,Q134,Q135,Q136,Q137,Q138,Q139,Q140,Q141,Q142,Q143,Q144,Q145,Q146,Q147,Q148,Q149,Q150 | ||
,,,,12345678,,a.jpg,80.0,4,1,1,0,1,1 | ||
,,,,12334235,,b.jpg,80.0,4,1,0,1,1,1 | ||
,,,,12345678,,a.jpg,80.0,4,1,1,0,1,1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Last Name,First Name,Middle Name,Test Form Code,Student ID,Course ID,Source File,Q1,Q2,Q3,Q4,Q5 | ||
,,,,12334235,,90deg.jpg,A,,C,D,E | ||
,,,,12334235,,180deg.jpg,A,,C,D,E | ||
,,,,12334235,,270deg.jpg,A,,C,D,E | ||
,,,,12334235,,90deg.jpg,A,,C,D,E |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change to
PyInstaller>=4.6
, but I'm confused by the change fromtyping
(the type-checking tool) toPillow
(an image processing library). Was that an intentional change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pillow is the python library to use the PIL image library package. I ended up with it for something, maybe PyInstaller. I will look back at it.
typing
is not required for python 3.9+ as it is included. As the current python is 3.10, I am trying to update this to work with that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will get to the rest of these this weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't know that. 👍 to removing the dependency then, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have to figure out why I had to add Pillow. I think it is for icon building for MacOS.
Revert the scrolling frame changes
Revert the change from using / to join paths (if you do find this causes any issues, please open an issue and I can take another look at it)
Remove the test_ files -- I definitely agree with having more tests but we can open issues instead of adding TODO comments, that way all the work is tracked in one place
Revert the requirements change from typing==3.7.4.1 to Pillow==9.2.0; this looks like a mistake (please correct me if I'm wrong!)