Fish completions #18
Open
Fish completions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey neat! Yeah, it looks great. Could you update the readme with instructions on how to install the completions? (Maybe this is just known for fish users and not necessary?) |
|
Sorry for the delay, been a bit busy lately. Updated the docs with a description of how to manually install. I will loop back around and update the nix instructions if needed once this is packaged. |
|
Awesome work! Any chance of getting this merged up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this as a PR, and removing the link to the fish shell completions gist (the link was broken anyways after I renamed my account). If you don't want the completions merged, I can remove the completions script and just update the docs for the correct link.
The fish shell completions now respect SD_ROOT and should work fine. I've used this daily since I wrote it 1.5 years ago, and have never needed to fix anything. Note that this also works for completing the special commands
cat edit help new which, which the zsh completions don't handle.I will update home-manager, and the docs for that, myself if you want to merge this.