Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish completions #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

arcuru
Copy link

@arcuru arcuru commented Nov 8, 2023

Opening this as a PR, and removing the link to the fish shell completions gist (the link was broken anyways after I renamed my account). If you don't want the completions merged, I can remove the completions script and just update the docs for the correct link.

The fish shell completions now respect SD_ROOT and should work fine. I've used this daily since I wrote it 1.5 years ago, and have never needed to fix anything. Note that this also works for completing the special commands cat edit help new which, which the zsh completions don't handle.

I will update home-manager, and the docs for that, myself if you want to merge this.

@ianthehenry
Copy link
Owner

Hey neat! Yeah, it looks great. Could you update the readme with instructions on how to install the completions? (Maybe this is just known for fish users and not necessary?)

@arcuru
Copy link
Author

arcuru commented Nov 21, 2023

Sorry for the delay, been a bit busy lately.

Updated the docs with a description of how to manually install. I will loop back around and update the nix instructions if needed once this is packaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants