Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: facebook extractor #1029

Merged
merged 2 commits into from
Feb 19, 2022
Merged

fix: facebook extractor #1029

merged 2 commits into from
Feb 19, 2022

Conversation

axetroy
Copy link
Collaborator

@axetroy axetroy commented Feb 19, 2022

close #1021
close #500

@axetroy axetroy changed the title fix: facebook extractors fix: facebook extractor Feb 19, 2022
@axetroy
Copy link
Collaborator Author

axetroy commented Feb 19, 2022

/cc @iawia002

extractors/facebook/facebook.go Outdated Show resolved Hide resolved

qualityRegMap := map[string]*regexp.Regexp{
"sd": regexp.MustCompile(`"playable_url":\s*"([^"]+)"`),
// "hd": regexp.MustCompile(`"playable_url_quality_hd":\s*"([^"]+)"`),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为啥又注释掉了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为虽然 fb 返回了这个地址,但这个地址直接访问时访问不了的,返回 403,可能还需要一些额外的参数,比如签名等。

目前没有搞清楚,所以只能先注释起来

extractors/facebook/facebook_test.go Show resolved Hide resolved
Co-authored-by: Xinzhao Xu <z2d@jifangcheng.com>
Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@iawia002 iawia002 merged commit 60cafd8 into iawia002:master Feb 19, 2022
@axetroy axetroy deleted the facebook branch February 22, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

facebook video 無法下載 facebook好像不行了
2 participants