Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and extract icons missing #57

Closed
cimarronline opened this issue Mar 24, 2018 · 6 comments
Closed

Add and extract icons missing #57

cimarronline opened this issue Mar 24, 2018 · 6 comments
Labels

Comments

@cimarronline
Copy link

cimarronline commented Mar 24, 2018

In version 0.5.4.13 the add and extract icons are missing from the interface for me. Only small dots appear, though these are clickable. Occurs in gtk3 and gtk2 versions. Changing icon themes (or icon sizes) does not seem to affect it.

Reverting this commit restores add and extract icons: b19a332

@ib ib added the question label Mar 24, 2018
@ib
Copy link
Owner

ib commented Mar 24, 2018

Strange.

Do you have the ability to patch and compile xarchiver and send me stderr output from the terminal? If so, I'd provide you with patches to track that issue down.

@cimarronline
Copy link
Author

Yes, I'll give it a try. I'm not very experienced with patches, but I managed to make one to revert that commit.

@ib
Copy link
Owner

ib commented Mar 24, 2018

Let's try something simple first. Type find / -name "xarchiver-add*" 2> /dev/null. Is there any output?

@cimarronline
Copy link
Author

cimarronline commented Mar 24, 2018

Yes:

/usr/share/pixmaps/xarchiver/adapta/xarchiver-add.png
/usr/share/pixmaps/xarchiver/xarchiver-add.png
/usr/share/icons/hicolor/24x24/actions/xarchiver-add.png
/usr/share/icons/xarchiver-add.png
/usr/share/icons/Menda-Circle/actions/scalable/xarchiver-add.png

The ones in Menda-Circle and hicolor I added (while troubleshooting) to see if xarchiver would grab them from the icon themes. No effect, though. The other extra ones are just copies I use to replace the default pixmap icon that comes with xarchiver, to make those icons match the icon theme.

@ib
Copy link
Owner

ib commented Mar 24, 2018

Well, that's a lot. Let's see what gets loaded.

Extract the attached patch - for example - in /tmp, change to xarchiver's source directory and apply it by patch -p1 < /tmp/issue57.patch. Compile, run src/xarchiver and post the output.

[issue57.zip]

@cimarronline
Copy link
Author

cimarronline commented Mar 25, 2018

Somehow in the process of running and rerunning and switching icon themes (and switching back), the icons started appearing (first one, then both). Not sure what made it work. The output from the patched xarchiver was:

0: /home/munn/.local/share/icons
1: /home/munn/.icons
2: /usr/local/share/icons
3: /usr/share/icons
4: /usr/local/share/pixmaps
5: /usr/share/pixmaps

Does that mean it was getting the icons from /usr/share/pixmaps/xarchiver? Anyway, thanks for taking the time (and thanks for xarchiver!). I did learn some more about patching in the process. I'll close this.

@ib ib added invalid and removed question labels Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants