Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waf+jni+jdk10+ : not supported #423

Closed
cprudhom opened this issue Nov 6, 2019 · 5 comments
Closed

Waf+jni+jdk10+ : not supported #423

cprudhom opened this issue Nov 6, 2019 · 5 comments
Assignees

Comments

@cprudhom
Copy link

cprudhom commented Nov 6, 2019

Hi,

I'm considering migrating Choco to JDK11.
To do so, I also need Ibex to be updated, but since JDK10, javah is not available and the script fails:

+./waf configure --enable-shared --with-jni --java-package-name=org.chocosolver.solver.constraints.real
Setting top to                           : /home/travis/build/chocoteam/choco-solver/ibex-lib-ibex-2.6.5 
Setting out to                           : /home/travis/build/chocoteam/choco-solver/ibex-lib-ibex-2.6.5/__build__ 
...
Checking for program 'javac'                  : /usr/local/lib/jvm/openjdk11/bin/javac 
Checking for program 'java'                   : /usr/local/lib/jvm/openjdk11/bin/java 
Checking for program 'jar'                    : /usr/local/lib/jvm/openjdk11/bin/jar 
Checking for program 'javadoc'                : /usr/local/lib/jvm/openjdk11/bin/javadoc 
Checking for program 'javah'                  : not found 
Could not find the program ['javah']

Is there any chance that the waf script takes java version into account ?

Best,
CP

@gchabert
Copy link
Contributor

gchabert commented Nov 7, 2019

Oh, yes, someone already mentioned this... #379
I'm on it.

@gchabert gchabert self-assigned this Nov 7, 2019
gchabert pushed a commit that referenced this issue Nov 7, 2019
@gchabert
Copy link
Contributor

gchabert commented Nov 7, 2019

Charles, I've commited a tentative fix on the develop branch.
Can you switch to this branch and try again ?
A new release is about to be issued, I'll integrate this fix if it works.

gchabert pushed a commit that referenced this issue Nov 11, 2019
@gchabert
Copy link
Contributor

I think it is ok now.

@cprudhom
Copy link
Author

That works like a charm.
I just noticed that "Pi" was renamed to "pi", is that correct ?

@gchabert
Copy link
Contributor

I think it has always been "pi". Are you sure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants