Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6549: Implemeted redesign loader #1001

Merged
merged 1 commit into from
Nov 22, 2023
Merged

IBX-6549: Implemeted redesign loader #1001

merged 1 commit into from
Nov 22, 2023

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Nov 21, 2023 •
edited

Question Answer
Tickets IBX-6549
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Implemeted redesign loader

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

micszo
micszo approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(CI is affected by recent merges)

@micszo micszo removed their assignment Nov 22, 2023
@dew326 dew326 merged commit aed7d88 into main Nov 22, 2023
22 of 23 checks passed
@dew326 dew326 deleted the ibx-6549-redesign-loader branch November 22, 2023 09:33
@micszo micszo mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 Awaiting requested review from dew326

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Gengar-i @GrabowskiM @micszo @lucasOsti @mikadamczyk @Nattfarinn @ciastektk @dew326 @ViniTou