IBX-7173: As the user I want to see empty state message in dropdown while filtering #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
requested review from
adamwojs,
tischsoic,
dew326,
lucasOsti and
Gengar-i
dew326
requested changes
Nov 24, 2023
| @@ -183,6 +183,13 @@ | |||
| {% include list_item_template_path with { choice, custom_form, icon: item_icon, icon_class: item_icon_class } %} | |||
| {% endfor %} | |||
| </ul> | |||
|
|
|||
| <div class="ibexa-dropdown__items-list-filter-empty" hidden> | |||
| <svg> | |||
There was a problem hiding this comment.
Here there's no point for this class - this class sets width and height of an element to 2rem and I need for this svg to be of dynamic size (based on widget width)
Gengar-i
approved these changes
Nov 25, 2023
lucasOsti
approved these changes
Nov 28, 2023
adamwojs
approved these changes
Nov 29, 2023
|
@GrabowskiM Rebase is needed here |
GrabowskiM
force-pushed
the
IBX-7173-filter-empty-message
branch
from
a846206
to
6f00340
Compare
GrabowskiM
force-pushed
the
IBX-7173-filter-empty-message
branch
from
6f00340
to
fda3104
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change started as thing for site access widget, but at the end done to all dropdowns in whole system...
Checklist:
$ composer fix-cs)