IBX-7126: Allowed passing extra parameters to pager of "My Drafts" tab #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
approved these changes
Nov 27, 2023
adamwojs
approved these changes
Nov 27, 2023
alongosz
changed the title
alongosz
force-pushed
the
ibx-7126-dashboard-my-drafts-pagination
branch
from
27c0d42
to
419ffd9
Compare
|
Update: the solution got slightly simplified and coverage was added. |
Nattfarinn
approved these changes
Dec 4, 2023
konradoboza
approved these changes
Dec 4, 2023
alongosz
force-pushed
the
ibx-7126-dashboard-my-drafts-pagination
branch
from
419ffd9
to
840a776
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
micszo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6When "My Drafts" Dashboard tab is rendered as a Customizable Dashboard Builder block, neither original request route name nor pagination parameter is available in a current context.
Parameters, in the end, after a few iterations, were seamlessly copied from main request to the block-rendering request via https://github.com/ibexa/dashboard/pull/53.
This PR allows merging extra Pagerfanta options coming from a template (see https://github.com/ibexa/dashboard/pull/53 for usage - passed extra
routeName) with current rendering options.Because of high coupling between MyDraftsTab and Twig Environment, I needed to stub Twig Environment to add test coverage for the change.
TODO
pager_optionsChecklist:
$ composer fix-cs).