Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7329: Enhancing UX: Name Updates for Product 4.6 LTS+ #1040

Merged
merged 12 commits into from
Dec 14, 2023
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Dec 10, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7329
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs marked this pull request as ready for review December 10, 2023 21:06
Copy link
Contributor

@mikadamczyk mikadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In few places, when FocusMode is evaluated, the line could be split to not exceed character limit

src/bundle/Resources/translations/messages.en.xliff Outdated Show resolved Hide resolved
@mikadamczyk mikadamczyk requested a review from a team December 11, 2023 07:07
@konradoboza konradoboza requested a review from a team December 11, 2023 07:13
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The distraction free mode does not open (the tooltip is displayed on hover, but clicking the button when creating an Article does nothing)
  2. The translations for the current state of Focused mode are missing in User Settings
Zrzut ekranu 2023-12-12 o 15 42 27 Zrzut ekranu 2023-12-12 o 15 44 54

@mnocon
Copy link
Contributor

mnocon commented Dec 12, 2023

Another issue detected by Behat: it's not possible to configure Text block in Page Builder editor after this changes.

The block configuration does not open - and the following exceptions happens:

    │  	[2023-12-12T14:24:07.921143+00:00] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "Block "focus_mode" on template "bootstrap_5_layout.html.twig" does not exist." at /var/www/vendor/ibexa/page-builder/src/bundle/Resources/views/page_builder/block/form_fields.html.twig line 26 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): Block \"focus_mode\" on template \"bootstrap_5_layout.html.twig\" does not exist. at /var/www/vendor/ibexa/page-builder/src/bundle/Resources/views/page_builder/block/form_fields.html.twig:26)"} []
    │  	[2023-12-12T14:24:08.320308+00:00] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "Block "focus_mode" on template "bootstrap_5_layout.html.twig" does not exist." at /var/www/vendor/ibexa/page-builder/src/bundle/Resources/views/page_builder/block/form_fields.html.twig line 26 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): Block \"focus_mode\" on template \"bootstrap_5_layout.html.twig\" does not exist. at /var/www/vendor/ibexa/page-builder/src/bundle/Resources/views/page_builder/block/form_fields.html.twig:26)"} []

@adamwojs
Copy link
Member Author

adamwojs commented Dec 13, 2023

Another issue detected by Behat: it's not possible to configure Text block in Page Builder editor after this changes.

Indeed, PB counterpart was missing: https://github.com/ibexa/page-builder/pull/314 and https://github.com/ibexa/fieldtype-page/pull/104

@adamwojs
Copy link
Member Author

All issues should be fixed now 😉

Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

7 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@webhdx webhdx merged commit 06ec786 into main Dec 14, 2023
15 of 18 checks passed
@webhdx webhdx deleted the ibx_7329 branch December 14, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants