-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7329: Enhancing UX: Name Updates for Product 4.6 LTS+ #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In few places, when FocusMode is evaluated, the line could be split to not exceed character limit
src/bundle/Resources/public/scss/fieldType/edit/_base-field.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another issue detected by Behat: it's not possible to configure Text block in Page Builder editor after this changes. The block configuration does not open - and the following exceptions happens:
|
Indeed, PB counterpart was missing: https://github.com/ibexa/page-builder/pull/314 and https://github.com/ibexa/fieldtype-page/pull/104 |
All issues should be fixed now 😉 |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 7 New issues |
Checklist:
$ composer fix-cs
)