IBX-7376: Fixed redirect to the not-existing menu after switching to focus mode

[konradoboza]

Question	Answer
Tickets	IBX-7376
Bug fix?	yes
New feature?	no
BC breaks?	no
Tests pass?	yes
Doc needed?	no

After switching to "focus mode" there are some sections that are no longer visible in the menu. It makes sense to redirect to the "Content structure" by default (agreed upon with UX team) whenever that happens.

It's not really reliable to those sections automatically due to variety of urls being part of menu items. Therefore I registered two basic strategies:

• OriginalUrlRedirectStrategy which basically is a projection of the current behavior,
• ContentStructureRedirectStrategy fixing the issue by detecting affected paths and redirecting to the default content structure menu.

Both implement Ibexa\Contracts\AdminUi\FocusMode\RedirectStrategyInterface which is an extension point allowing to circumvent the default behavior:

interface RedirectStrategyInterface
{
    public function supports(string $route): bool;

    public function generateRedirectPath(string $originalPath): string;
}

New strategy can be registered as follows:

App\CustomRedirectStrategy:
    tags:
        - { name: ibexa.admin_ui.focus_mode.redirect_strategy, priority: 10 }

Documentation:

It's worth mentioning the above extension point for adding custom focus mode redirect strategies.

Checklist:

• Coding standards ($ composer fix-cs)
• Ready for Code Review

[alongosz]

Shouldn't this list be configurable?

[konradoboza]

To me - not necessarily. It might look like an extension point nobody would really use. The thing is, we are lacking a proper list of columns/paths unavailable in focus mode which can be referenced here. That's why I decided to hardcode them and give a way to circumvent the default behavior by registering another strategy at the same time. To me, Open-Closed principle holds it ground in this case. 😉

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[bogusez]

Regression tests passed