Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7604: Fixed checkbox toggler #1142

Merged
merged 1 commit into from
Jan 31, 2024
Merged

IBX-7604: Fixed checkbox toggler #1142

merged 1 commit into from
Jan 31, 2024

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Jan 31, 2024 •
edited by konradoboza
Loading

Question Answer
JIRA issue IBX-7604
Type bug
Target version v4.6
BC breaks no
Doc needed no

Companion PR: https://github.com/ibexa/product-catalog/pull/1131

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucasOsti lucasOsti changed the base branch from main to 4.5 January 31, 2024 11:11
konradoboza
konradoboza approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR against 4.5 branch though.

@konradoboza konradoboza added Bug Something isn't working Ready for QA labels Jan 31, 2024
@konradoboza konradoboza merged commit 9459a4b into 4.5 Jan 31, 2024
23 of 24 checks passed
@konradoboza konradoboza deleted the ibx-7604-measurement-range-toggle-blocked-for-variants branch January 31, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@konradoboza konradoboza konradoboza approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@Gengar-i Gengar-i Awaiting requested review from Gengar-i

Assignees

@dew326 dew326

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasOsti @tischsoic @dew326 @konradoboza @katarzynazawada