Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7720: Fixed content-type not highlighted in COTF #1158

Merged
merged 1 commit into from
Feb 21, 2024
Merged

IBX-7720: Fixed content-type not highlighted in COTF #1158

merged 1 commit into from
Feb 21, 2024
+1 −1

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Feb 7, 2024

Question Answer
JIRA issue IBX-7720
Type bug
Target version v4.6
BC breaks no
Doc needed no

Fixed conent-type not highlighter in COTF

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gengar-i Gengar-i changed the title IBX-7720: Fixed conent-type not highlighter in COTF IBX-7720: Fixed content-type not highlighter in COTF Feb 7, 2024
@Gengar-i Gengar-i changed the title IBX-7720: Fixed content-type not highlighter in COTF IBX-7720: Fixed content-type not highlighted in COTF Feb 7, 2024
@tomaszszopinski tomaszszopinski self-assigned this Feb 21, 2024
tomaszszopinski
tomaszszopinski approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP commerce 4.6

@dew326 dew326 merged commit f194967 into main Feb 21, 2024
24 checks passed
@dew326 dew326 deleted the ibx-7720-content-type-not-highlighter branch February 21, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@dew326 dew326

@tomaszszopinski tomaszszopinski

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gengar-i @GrabowskiM @dew326 @lucasOsti @tomaszszopinski