Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7653: Allow filtering for loadSubtreeAction #1161

Merged
merged 6 commits into from
May 16, 2024
Merged

IBX-7653: Allow filtering for loadSubtreeAction #1161

merged 6 commits into from
May 16, 2024

Conversation

tischsoic
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7653
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from 89a58ae to 16ebaa5 Compare February 22, 2024 08:29
@tischsoic
Copy link
Contributor Author

Depends on other PR, regression run in: ibexa/commerce#701.

@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from a295c01 to ee0cd1b Compare February 22, 2024 11:14
@tischsoic tischsoic marked this pull request as ready for review February 22, 2024 11:27
@tischsoic tischsoic requested a review from a team February 22, 2024 11:28
@tischsoic tischsoic changed the base branch from main to 4.6 March 25, 2024 08:52
@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch 2 times, most recently from a83de64 to 94d5fd5 Compare March 26, 2024 10:43
@Steveb-p Steveb-p requested a review from a team April 4, 2024 12:17
konradoboza
konradoboza approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Paweł's comments.

@konradoboza konradoboza requested a review from a team April 4, 2024 12:20
@tischsoic tischsoic requested a review from Steveb-p April 5, 2024 07:50
@adamwojs adamwojs changed the title IBX-7653: allow filtering for loadSubtreeAction IBX-7653: Allow filtering for loadSubtreeAction Apr 5, 2024
@Steveb-p Steveb-p mentioned this pull request Apr 17, 2024
Merged
@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch 2 times, most recently from 4429c28 to 1c8aad0 Compare April 18, 2024 09:33
@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from e59ea35 to 5709af8 Compare May 10, 2024 07:38
This was referenced May 10, 2024
Closed
Closed
Closed
@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from e301745 to fadfda7 Compare May 16, 2024 06:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tischsoic
Copy link
Contributor Author

CI may be failing because [TMP] commits have been removed.

@dew326 dew326 merged commit ca438ee into 4.6 May 16, 2024
22 checks passed
@dew326 dew326 deleted the IBX-7653-images-visible-in-tree-browser-in-image-picker branch May 16, 2024 07:21
@tischsoic
Copy link
Contributor Author

Merged up:

GrabowskiM pushed a commit that referenced this pull request May 27, 2024
@tischsoic @GrabowskiM
IBX-7653: Allow filtering for loadSubtreeAction (#1161)
c144479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@bogusez bogusez bogusez approved these changes

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tischsoic @adamwojs @Steveb-p @konradoboza @bogusez @mikadamczyk @Nattfarinn @ciastektk @dew326 @ViniTou