Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7112: Tabs class extension added #1196

Merged
merged 4 commits into from
Mar 28, 2024
Merged

IBX-7112: Tabs class extension added #1196

merged 4 commits into from
Mar 28, 2024

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Mar 1, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7112
Type bug
Target version v4.6
BC breaks no
Doc needed no

Done:

  • Tabs class extension added
  • Fixed issue with filter not showing placeholder.
  • Updated validation labels on front side.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

dew326
dew326 requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misclick :)

GrabowskiM
GrabowskiM approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@GrabowskiM GrabowskiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Darek comment about translations it's ok

@Gengar-i Gengar-i requested a review from dew326 March 7, 2024 10:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gengar-i Gengar-i changed the base branch from main to 4.6 March 15, 2024 09:05
@juskora juskora mentioned this pull request Mar 27, 2024
Closed
@juskora
Copy link
Contributor

juskora commented Mar 28, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@dew326 dew326 merged commit 23264d2 into 4.6 Mar 28, 2024
23 checks passed
@dew326 dew326 deleted the ibx-7112-config-panel-btns branch March 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juskora juskora juskora approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Gengar-i @juskora @mikadamczyk @GrabowskiM @dew326 @lucasOsti @Nattfarinn @ciastektk @ViniTou